Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #7028 - fixing api docs for orgs #4603

Merged
merged 1 commit into from
Aug 27, 2014
Merged

Fixes #7028 - fixing api docs for orgs #4603

merged 1 commit into from
Aug 27, 2014

Conversation

tstrachota
Copy link
Member

Adding all taxonomy parameters inherited from Foreman. Important for the CLI to build the parameters correctly.

Requires:
Apipie/apipie-rails#280 MERGED; apipie-rails 0.2.5 built and released
theforeman/foreman#1707

@mbacovsky
Copy link
Contributor

👍 looks good, fixed the issue. Thanks!

@@ -51,6 +53,7 @@ def show
param :id, :identifier, :desc => N_("organization ID"), :required => true
param :description, String, :desc => N_("description of the organization"), :required => false
param :redhat_repository_url, String, :desc => N_("Redhat CDN url")
param_group :resource, ::Api::V2::TaxonomiesController
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is only necessary for update and create ?

edit: answered my own question. carry on!

@komidore64
Copy link
Contributor

ack

@komidore64
Copy link
Contributor

waiting on theforeman/foreman#1707

@tstrachota
Copy link
Member Author

Tests are green: http://ci.theforeman.org/job/test_katello_pull_request/4133/ (run manually)

@jlsherrill
Copy link
Member

[test]

@jlsherrill
Copy link
Member

ACK

@komidore64
Copy link
Contributor

@jlsherrill so this is good?

komidore64 added a commit that referenced this pull request Aug 27, 2014
@komidore64 komidore64 merged commit e1229e3 into Katello:master Aug 27, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants