Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preserve comments in gradle.properties #569

Closed
jcapogna opened this issue Dec 29, 2023 · 3 comments · Fixed by #570
Closed

Preserve comments in gradle.properties #569

jcapogna opened this issue Dec 29, 2023 · 3 comments · Fixed by #570
Assignees
@KengoTODA
Labels
released

Comments

@jcapogna
Copy link

When saving the new version in gradle.properties, the file is rewritten and any comments are stripped out as a result. Is it possible to only update the version property and leave the rest of the file intact?
@KengoTODA
Copy link
Owner

This feature needs breaking changes in https://github.com/KengoTODA/promisified-properties repo, I'll track this request as KengoTODA/promisified-properties#665

@KengoTODA KengoTODA self-assigned this Dec 31, 2023
KengoTODA added a commit that referenced this issue Dec 31, 2023
@KengoTODA
feat: preserve comments in properties file
79a01f4 
close #569

Signed-off-by: Kengo TODA <[email protected]>
@KengoTODA KengoTODA mentioned this issue Dec 31, 2023
Merged
KengoTODA added a commit that referenced this issue Dec 31, 2023
@KengoTODA
feat: preserve comments in properties file
0bbb179 
close #569

Signed-off-by: Kengo TODA <[email protected]>
KengoTODA pushed a commit that referenced this issue Dec 31, 2023
@semantic-release-bot
chore(release): 1.9.0 [skip ci]
f567a01 
# [1.9.0](v1.8.0...v1.9.0) (2023-12-31)

### Features

* preserve comments in properties file ([0bbb179](0bbb179)), closes [#569](#569)
@KengoTODA
Copy link
Owner

🎉 This issue has been resolved in version 1.9.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@jcapogna
Copy link
Author

jcapogna commented Jan 1, 2024

Thanks @KengoTODA

This still removes blank lines, but it does preserve line order and comments. Saving blank lines would be a nice plus if possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@KengoTODA KengoTODA

Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Preserve comments in gradle.properties KengoTODA/gradle-semantic-release-plugin
2 participants
@KengoTODA @jcapogna