-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
controller rework #354
Merged
Merged
controller rework #354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h i was using to build out the imgui side of things
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
soh PRs to get builds:
Single Player Mode: HarbourMasters/Shipwright#3331
Multiplayer Mode: HarbourMasters/Shipwright#3354
todo:
i think clear isn't clearing the device index mapping ids? pressing clear all and then reorder isn't setting defaultsdo uuids in a good waydon't use uuidsAxisDirectionToButtonMapping
) - the current implementation has "use axis deadzone for buttons" but that feels kinda messy and it won't work with the new architecture. a global threshold for presses is probably a good thing to have, but that doesn't take into account different thresholds for triggers vs sticks, so just allowing the user to configure one value isn't quite good enough.v2 todo (decided it's out of scope for this PR but it'd still be cool):
hold
vsnunchuck.hold
)___ToHotkeyMapping
(this would get us remappable hotkeys)ControllerStick
/ControllerButton
/ControllerGyro
/ControllerRumble
/ControllerLED
(maybe just wait and do this as part of attachments)migrate from old configsnitpick appendix:
current behavior:
then quit and restart game and sometimes see
i know this has to do with
UpdateBitmaskToMappingUuids
inInputEditorWindow.cpp
not having any sense of the order they were added in, not sure how much complexity this would add/if it's worth it