-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ssd1306 base #50
base: Dmytro.Kirtoka
Are you sure you want to change the base?
ssd1306 base #50
Conversation
dev_info(&drv_client->dev, "%s: enter\n", __func__); | ||
} | ||
|
||
static void i2c_ssd1306_copyarea(struct fb_info *info, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why have you desided to refuse of these methods' functional and just use write method?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did the minimum possible driver functionality for my purposes (vizualization app)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point of using update thread!
Nevertheless could you please make changes listed below?
.fb_blank = i2c_ssd1306_blank, | ||
.fb_fillrect = i2c_ssd1306_fillrect, | ||
.fb_copyarea = i2c_ssd1306_copyarea, | ||
.fb_imageblit = i2c_ssd1306_imageblit, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess these initialisation could be siplier since you didn't use most of framebuffer methods
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe, but I left a message output, what if something is needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please split the PR into functional commits
this driver was written from an empty sheet, |
👍 I see.
I hope at least *.dtsi hasn't been written from an empty sheet. |
Add update screen thread and write op
237b663
to
cf55c51
Compare
split to functional parts |
@dmytrokirtoka, |
added simple lcd driver communicated with i2c interface
driver supports frame buffer read/write only
this operations enough to use for its purpose
Signed-off-by: dmytro.kirtoka [email protected]