Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ssd1306 base #50

Open
wants to merge 4 commits into
base: Dmytro.Kirtoka
Choose a base branch
from

Conversation

dmytrokirtoka
Copy link

added simple lcd driver communicated with i2c interface
driver supports frame buffer read/write only
this operations enough to use for its purpose

Signed-off-by: dmytro.kirtoka [email protected]

dev_info(&drv_client->dev, "%s: enter\n", __func__);
}

static void i2c_ssd1306_copyarea(struct fb_info *info,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why have you desided to refuse of these methods' functional and just use write method?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did the minimum possible driver functionality for my purposes (vizualization app)

Copy link

@DevyatovAndrey DevyatovAndrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point of using update thread!

Nevertheless could you please make changes listed below?

.fb_blank = i2c_ssd1306_blank,
.fb_fillrect = i2c_ssd1306_fillrect,
.fb_copyarea = i2c_ssd1306_copyarea,
.fb_imageblit = i2c_ssd1306_imageblit,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess these initialisation could be siplier since you didn't use most of framebuffer methods

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe, but I left a message output, what if something is needed?

Copy link
Collaborator

@AleksandrBulyshchenko AleksandrBulyshchenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please split the PR into functional commits

@dmytrokirtoka
Copy link
Author

this driver was written from an empty sheet,
please specify what exactly should be divided?

@AleksandrBulyshchenko
Copy link
Collaborator

this driver was written from an empty sheet,

👍 I see.

please specify what exactly should be divided?

I hope at least *.dtsi hasn't been written from an empty sheet.

@dmytrokirtoka
Copy link
Author

split to functional parts

@AleksandrBulyshchenko
Copy link
Collaborator

@dmytrokirtoka,
Please fill commit messages with more details.
Especially when add *.dtsi - provide information about its origin (repository, path, version).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants