mpu6050:Add shell script for get temperature from mpu6050 #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yekovalyov
added
changes requested
|
Please attach the results of script's execution. |
ghostzero2000
force-pushed
the
mpu6050_userspace_solution_ver_02
branch
from
ab047e5 to
20853cd
Compare
|
Added the screenshot with the result of the script's execution. |
ghostzero2000
added
ready
|
Did You check the value of temperature? Are they correct? |
yekovalyov
added
changes requested
ghostzero2000
force-pushed
the
mpu6050_userspace_solution_ver_02
branch
from
20853cd to
67b8175
Compare
|
Hello. I found a mistake, I perceived the variable as unsigned. Now it is a value 16 bit signed |
ghostzero2000
added
ready
|
Please attach the results of script execution in format of text file. |
yekovalyov
added
changes requested
ghostzero2000
force-pushed
the
mpu6050_userspace_solution_ver_02
branch
from
67b8175 to
b79cd83
Compare
|
Attached file "mpu6050_get_temp_C_and_F.log" which content of script execution. |
ghostzero2000
added
ready
yekovalyov
reviewed
Dec 16, 2019
yekovalyov
added
changes requested
ghostzero2000
force-pushed
the
mpu6050_userspace_solution_ver_02
branch
from
b79cd83 to
76f161e
Compare
ghostzero2000
added
ready
|
Like I cleaned everything. |
yekovalyov
reviewed
Dec 26, 2019
Comment on lines
12
to
28
| function get_temperature { | ||
| H_BYTE_MPU6060=$(i2cget -y 0 0x68 0x41 b) | ||
| L_BYTE_MPU6060=$(i2cget -y 0 0x68 0x42 b) | ||
| TWO_BYTE_HEX="${H_BYTE_MPU6060:2}${L_BYTE_MPU6060:2}" | ||
| TWO_BYTE_DEC_convert=$(conv_16_bit_hex_dec_signed $TWO_BYTE_HEX ) | ||
| # echo "TWO_BYTE_DEC=$TWO_BYTE_DEC_convert" | ||
| echo "Temp TWO_BYTE_HEX $( echo "scale=3; $TWO_BYTE_DEC_convert/340+36.53" | bc)" | ||
| echo "Temp Fahrenheit $(echo "scale=3; (($TWO_BYTE_DEC_convert/340+36.53)*9)/5+32" | bc)" | ||
|
|
||
| } |
There was a problem hiding this comment.
Can You implement the conversation without additional call of printf and using out from i2cget with option -w
There was a problem hiding this comment.
The changes are not implemented.
yekovalyov
added
changes requested
ghostzero2000
force-pushed
the
mpu6050_userspace_solution_ver_02
branch
3 times, most recently
from
bc1f8b5 to
7071531
Compare
ghostzero2000
added
ready
|
Update shell script with i2cget option w |
|
The additional commit from other task was included in this PR. Please rebase your PR. |
yekovalyov
added
changes requested
ghostzero2000
force-pushed
the
mpu6050_userspace_solution_ver_02
branch
from
7071531 to
7323aae
Compare
ghostzero2000
added
ready
|
In the pull request is one commit that belongs to this task. |
yekovalyov
reviewed
Jan 14, 2020
Comment on lines
18
to
24
| echo "Temp TWO_BYTE_HEX $( echo "scale=3; $TWO_BYTE_DEC_convert/340+36.53" | bc)" | ||
| echo "Temp Fahrenheit $(echo "scale=3; (($TWO_BYTE_DEC_convert/340+36.53)*9)/5+32" | bc)" | ||
| LONG_WORD=$(i2cget -y 0 0x68 0x41 w) | ||
| CONVERT_LONG_WORD=$(((LONG_WORD & 0xFF)<<8 | (LONG_WORD>>8) & 0xFF)) | ||
| (( CONVERT_LONG_WORD > 32767 )) && (( CONVERT_LONG_WORD -= 65536 )) | ||
| Celsiy=$(bc -l <<< "scale=4;$CONVERT_LONG_WORD/340+36.53") | ||
| Fahrenheit=$(bc -l <<< "scale=4;$Celsiy*9/5+32") |
There was a problem hiding this comment.
What is the reason for different scale for file and for stdout output? Is the 4th digit after point significant?
yekovalyov
added
changes requested
Signed-off-by: Vladyslav <[email protected]>
ghostzero2000
force-pushed
the
mpu6050_userspace_solution_ver_02
branch
from
f37e80a to
aa9eb31
Compare
ghostzero2000
added
ready
|
The conversion from a simple fraction to a decimal fraction makes rounding significant for any number of decimal places. |
yekovalyov
reviewed
Jan 15, 2020
| Temp Celsiy 27.401 | ||
| Temp Fahrenheit 81.321 | ||
| Temp long_word | ||
| Celsius 27.40058823529411764706 |
There was a problem hiding this comment.
What is the value of least significant bit for this sensor? Are 20 digits after comma enough?
yekovalyov
added
changes requested
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add shell script for getting temperature from mpu6050 , log file with i2c commands and screenshot with it.