Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable blur by pressing enter when composing #1224

Merged
merged 1 commit into from
Aug 30, 2024
Merged

Disable blur by pressing enter when composing #1224

merged 1 commit into from
Aug 30, 2024

Conversation

akadateppei
Copy link
Contributor

Utilized MUI's onCompositionStart and onCompositionEnd:

  • Maintains a state to track whether the composition is complete.
  • Sets the state to false when composition starts.
  • Sets the state to true when composition ends.
  • Adds the above flag to the blur detection logic when the Enter key is pressed.

Here is the video after the fix. (The video before the fix can be found in the issue.)

2024-08-23.23.30.03.mov

@vercel Vercel
Copy link

vercel bot commented Aug 23, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
material-react-table ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 23, 2024 2:42pm
material-react-table-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 23, 2024 2:42pm

@akadateppei akadateppei mentioned this pull request Aug 27, 2024
Merged
@KevinVandy KevinVandy merged commit 3eecd63 into KevinVandy:v2 Aug 30, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KevinVandy KevinVandy KevinVandy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@akadateppei @KevinVandy