Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add VIA support for Keychron C2 Pro #6

Merged

Conversation

KeychronMacro
Copy link
Member

Added VIA JSONs for Keychron C2 Pro and request for a review, Thanks!

Description

  • Added c2_pro/c2_pro_ansi_rgb.json to v3/keychron
  • Added c2_pro/c2_pro_ansi_white.json to v3/keychron

QMK Pull Request

qmk/qmk_firmware#20701

Checklist

  • The VIA support for this keyboard is MERGED in QMK master already (MANDATORY)
  • The VIA definition follows the guide here: https://caniusevia.com/docs/layouts
  • I have a V3 JSON version for this keyboard definition.(MANDATORY)
  • I have tested this keyboard definition using VIA's "Design" tab.
  • I have tested this keyboard definition with firmware on a device.
  • I have assigned alpha keys and modifier keys with the correct colors.
  • The Vendor ID is not 0xFEED

@KeychronMacro KeychronMacro merged commit 7210d6c into Keychron:keychron-c2_pro Jun 21, 2023
@KeychronMacro KeychronMacro deleted the keychron-c2_pro branch June 21, 2023 03:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants