feat(helm): use helm release namespace for all namespaced resources #15
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explicit namespaced resources namespace value
Current Behavior
Current behavior is to rely on helm install capabilities to set resources namespace "just in time" during the setup phase.
This is working pretty well
The problem
The problem is that the namespace is not applied if we're doing the same thing using helm template :
This is caused by missing namespace value in helm templates for all namespaced resources (example for Deploy resource : https://github.com/Keyfactor/ejbca-cert-manager-issuer/blob/main/deploy/charts/ejbca-cert-manager-issuer/templates/deployment.yaml#L3-L6 )
This PR makes namespace value explicit in every resources that requires it, enabling a nice compatibility with
helm template
workflow.Thanks !