Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor Python API to be more pythonic - part 2 #321

Open
wants to merge 14 commits into
base: master
Choose a base branch
from
18 changes: 15 additions & 3 deletions python/src/addons/CompletionDictionaryCompiler.pyx
Original file line number Diff line number Diff line change
Expand Up @@ -5,14 +5,14 @@


def __setitem__(self, key, value):
self.Add(key, value)
self.add(key, value)


def __exit__(self, type, value, traceback):
self.Compile()
self.compile()


def Compile(self, *args):
def compile(self, *args):
if not args:
with nogil:
self.inst.get().Compile()
Expand All @@ -21,3 +21,15 @@
cdef void* callback = <void*> args[0]
with nogil:
self.inst.get().Compile(progress_compiler_callback, callback)

def Compile(self, *args):
return call_deprecated_method("Compile", "compile", self.compile, *args)

def Add(self, *args):
return call_deprecated_method("Add", "add", self.add, *args)

def SetManifest(self, *args):
return call_deprecated_method("SetManifest", "set_manifest", self.set_manifest, *args)

def WriteToFile(self, *args):
return call_deprecated_method("WriteToFile", "write_to_file", self.write_to_file, *args)
12 changes: 12 additions & 0 deletions python/src/addons/CompletionDictionaryMerger.pyx
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@


def Add(self, *args):
return call_deprecated_method("Add", "add", self.add, *args)

def Merge(self, *args):
return call_deprecated_method("Merge", "merge", self.merge, *args)

def SetManifest(self, *args):
return call_deprecated_method("SetManifest", "set_manifest", self.set_manifest, *args)


17 changes: 14 additions & 3 deletions python/src/addons/FloatVectorDictionaryCompiler.pyx
Original file line number Diff line number Diff line change
Expand Up @@ -5,14 +5,14 @@


def __setitem__(self, key, value):
self.Add(key, value)
self.add(key, value)


def __exit__(self, type, value, traceback):
self.Compile()
self.compile()


def Compile(self, *args):
def compile(self, *args):
if not args:
with nogil:
self.inst.get().Compile()
Expand All @@ -22,3 +22,14 @@
with nogil:
self.inst.get().Compile(progress_compiler_callback, callback)

def Compile(self, *args):
return call_deprecated_method("Compile", "compile", self.compile, *args)

def Add(self, *args):
return call_deprecated_method("Add", "add", self.add, *args)

def SetManifest(self, *args):
return call_deprecated_method("SetManifest", "set_manifest", self.set_manifest, *args)

def WriteToFile(self, *args):
return call_deprecated_method("WriteToFile", "write_to_file", self.write_to_file, *args)
4 changes: 4 additions & 0 deletions python/src/addons/ForwardBackwardCompletion.pyx
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@


def GetCompletions(self, *args):
return call_deprecated_method("GetCompletions", "complete", self.complete, *args)
25 changes: 23 additions & 2 deletions python/src/addons/Index.pyx
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@

self.inst.get().Delete(key)

def Get (self, key, default = None):
def get (self, key, default = None):
"""Return the value for key if key is in the dictionary, else default."""
if isinstance(key, unicode):
key = key.encode('utf-8')
Expand All @@ -50,6 +50,9 @@
py_result.inst = _r
return py_result

def Get(self, *args):
return call_deprecated_method("Get", "get", self.get, *args)

def __contains__(self, key):
if isinstance(key, unicode):
key = key.encode('utf-8')
Expand All @@ -72,7 +75,7 @@
py_result.inst = _r
return py_result

def MSet(self, list key_values ):
def mset(self, list key_values ):
assert isinstance(key_values, list), 'arg in_0 wrong type'
cdef shared_ptr[libcpp_vector[libcpp_pair[libcpp_utf8_string,libcpp_utf8_string]]] cpp_key_values = shared_ptr[libcpp_vector[libcpp_pair[libcpp_utf8_string,libcpp_utf8_string]]](new libcpp_vector[libcpp_pair[libcpp_utf8_string,libcpp_utf8_string]]())
cdef libcpp_pair[libcpp_utf8_string, libcpp_utf8_string] cpp_kv
Expand All @@ -92,3 +95,21 @@
cpp_key_values.get().push_back(cpp_kv)

self.inst.get().MSet(cpp_key_values)

def MSet(self, *args):
return call_deprecated_method("MSet", "mset", self.mset, *args)

def Set(self, *args):
return call_deprecated_method("Set", "set", self.set, *args)

def GetNear(self, *args):
return call_deprecated_method("GetNear", "get_near", self.get_near, *args)

def GetFuzzy(self, *args):
return call_deprecated_method("GetFuzzy", "get_fuzzy", self.get_fuzzy, *args)

def Delete(self, *args):
return call_deprecated_method("Delete", "delete", self.delete, *args)

def Flush(self, *args):
return call_deprecated_method("Flush", "flush", self.flush, *args)
18 changes: 15 additions & 3 deletions python/src/addons/IntDictionaryCompiler.pyx
Original file line number Diff line number Diff line change
Expand Up @@ -5,14 +5,14 @@


def __setitem__(self, key, value):
self.Add(key, value)
self.add(key, value)


def __exit__(self, type, value, traceback):
self.Compile()
self.compile()


def Compile(self, *args):
def compile(self, *args):
if not args:
with nogil:
self.inst.get().Compile()
Expand All @@ -22,3 +22,15 @@
with nogil:
self.inst.get().Compile(progress_compiler_callback, callback)

def Compile(self, *args):
return call_deprecated_method("Compile", "compile", self.compile, *args)

def Add(self, *args):
return call_deprecated_method("Add", "add", self.add, *args)

def SetManifest(self, *args):
return call_deprecated_method("SetManifest", "set_manifest", self.set_manifest, *args)

def WriteToFile(self, *args):
return call_deprecated_method("WriteToFile", "write_to_file", self.write_to_file, *args)

24 changes: 0 additions & 24 deletions python/src/addons/IntDictionaryCompilerSmallData.pyx

This file was deleted.

12 changes: 12 additions & 0 deletions python/src/addons/IntDictionaryMerger.pyx
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@


def Add(self, *args):
return call_deprecated_method("Add", "add", self.add, *args)

def Merge(self, *args):
return call_deprecated_method("Merge", "merge", self.merge, *args)

def SetManifest(self, *args):
return call_deprecated_method("SetManifest", "set_manifest", self.set_manifest, *args)


18 changes: 15 additions & 3 deletions python/src/addons/JsonDictionaryCompiler.pyx
Original file line number Diff line number Diff line change
Expand Up @@ -5,14 +5,14 @@


def __setitem__(self, key, value):
self.Add(key, value)
self.add(key, value)


def __exit__(self, type, value, traceback):
self.Compile()
self.compile()


def Compile(self, *args):
def compile(self, *args):
if not args:
with nogil:
self.inst.get().Compile()
Expand All @@ -22,3 +22,15 @@
with nogil:
self.inst.get().Compile(progress_compiler_callback, callback)

def Compile(self, *args):
return call_deprecated_method("Compile", "compile", self.compile, *args)

def Add(self, *args):
return call_deprecated_method("Add", "add", self.add, *args)

def SetManifest(self, *args):
return call_deprecated_method("SetManifest", "set_manifest", self.set_manifest, *args)

def WriteToFile(self, *args):
return call_deprecated_method("WriteToFile", "write_to_file", self.write_to_file, *args)

39 changes: 0 additions & 39 deletions python/src/addons/JsonDictionaryCompilerSmallData.pyx

This file was deleted.

12 changes: 12 additions & 0 deletions python/src/addons/JsonDictionaryMerger.pyx
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@


def Add(self, *args):
return call_deprecated_method("Add", "add", self.add, *args)

def Merge(self, *args):
return call_deprecated_method("Merge", "merge", self.merge, *args)

def SetManifest(self, *args):
return call_deprecated_method("SetManifest", "set_manifest", self.set_manifest, *args)


11 changes: 10 additions & 1 deletion python/src/addons/JsonVector.pyx
Original file line number Diff line number Diff line change
@@ -1,8 +1,17 @@


def Get(self, index ):
def __getitem__(self, index ):
assert isinstance(index, (int, long)), 'arg index wrong type'

cdef libcpp_utf8_string _r = self.inst.get().Get((<size_t>index))
py_result = json.loads(_r.decode('utf-8'))
return py_result

def Get(self, *args):
return call_deprecated_method("Get", "__getitem__", self.__getitem__, *args)

def Size(self, *args):
return call_deprecated_method("Size", "__len__", self.__len__, *args)

def Manifest(self, *args):
return call_deprecated_method("Manifest", "manifest", self.manifest, *args)
11 changes: 10 additions & 1 deletion python/src/addons/JsonVectorGenerator.pyx
Original file line number Diff line number Diff line change
@@ -1,5 +1,14 @@


def PushBack(self, in_0 ):
def append(self, in_0 ):
dumps = json.dumps(in_0).encode('utf-8')
self.inst.get().PushBack((<libcpp_utf8_string>dumps))

def PushBack(self, *args):
return call_deprecated_method("PushBack", "append", self.append, *args)

def SetManifest(self, *args):
return call_deprecated_method("SetManifest", "set_manifest", self.set_manifest, *args)

def WriteToFile(self, *args):
return call_deprecated_method("WriteToFile", "write_to_file", self.write_to_file, *args)
17 changes: 14 additions & 3 deletions python/src/addons/KeyOnlyDictionaryCompiler.pyx
Original file line number Diff line number Diff line change
Expand Up @@ -5,14 +5,14 @@


def __setitem__(self, key, value):
self.Add(key, value)
self.add(key, value)


def __exit__(self, type, value, traceback):
self.Compile()
self.compile()


def Compile(self, *args):
def compile(self, *args):
if not args:
with nogil:
self.inst.get().Compile()
Expand All @@ -22,3 +22,14 @@
with nogil:
self.inst.get().Compile(progress_compiler_callback, callback)

def Compile(self, *args):
return call_deprecated_method("Compile", "compile", self.compile, *args)

def Add(self, *args):
return call_deprecated_method("Add", "add", self.add, *args)

def SetManifest(self, *args):
return call_deprecated_method("SetManifest", "set_manifest", self.set_manifest, *args)

def WriteToFile(self, *args):
return call_deprecated_method("WriteToFile", "write_to_file", self.write_to_file, *args)
10 changes: 10 additions & 0 deletions python/src/addons/KeyOnlyDictionaryGenerator.pyx
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@


def Add(self, *args):
return call_deprecated_method("Add", "add", self.add, *args)

def CloseFeeding(self, *args):
return call_deprecated_method("CloseFeeding", "close_feeding", self.close_feeding, *args)

def WriteToFile(self, *args):
return call_deprecated_method("WriteToFile", "write_to_file", self.write_to_file, *args)
12 changes: 12 additions & 0 deletions python/src/addons/KeyOnlyDictionaryMerger.pyx
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@


def Add(self, *args):
return call_deprecated_method("Add", "add", self.add, *args)

def Merge(self, *args):
return call_deprecated_method("Merge", "merge", self.merge, *args)

def SetManifest(self, *args):
return call_deprecated_method("SetManifest", "set_manifest", self.set_manifest, *args)


4 changes: 4 additions & 0 deletions python/src/addons/MultiWordCompletion.pyx
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@


def GetCompletions(self, *args):
return call_deprecated_method("GetCompletions", "complete", self.complete, *args)
7 changes: 7 additions & 0 deletions python/src/addons/PrefixCompletion.pyx
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@


def GetCompletions(self, *args):
return call_deprecated_method("GetCompletions", "complete", self.complete, *args)

def GetFuzzyCompletions(self, *args):
return call_deprecated_method("GetFuzzyCompletions", "complete_fuzzy", self.complete_fuzzy, *args)
Loading
Loading