Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typings: File splitting #58

Closed
bsian03 opened this issue Feb 20, 2020 · 2 comments · Fixed by #59
Closed

Typings: File splitting #58

bsian03 opened this issue Feb 20, 2020 · 2 comments · Fixed by #59
Labels
t: typings

Comments

@bsian03
Copy link
Contributor

bsian03 commented Feb 20, 2020 •
edited
Loading

Creating just so we can keep track of stuff

File structure:

AxonCore
| typings
| | Definitions and subdefinitions
| | libraries
| | | Eris.ts
| | | DiscordJS.ts
| | | Detritus.ts
| | | index.ts (read off this file)
| | | Normal library typings - Includes library specific enums - default to contain Eris enums
| | misc
| | | interfaces.ts
| | | enums.ts - Only AxonEnums and DiscordEnums

I'll open and link PR once this is ready
@bsian03
Copy link
Contributor Author

bsian03 commented Feb 20, 2020

Obviously Detritus library specific typings won't be included as of yet

@Khaaz
Copy link
Owner

Khaaz commented Feb 20, 2020

The PR closing this issue will also includes:

  • dynamic typings (dynamically link with eris / discordjs typings)
    Via CLI (bin property in package.json)
    eg: yarn library <lib>.
  • CI update to lint all the typings folder

@bsian03 bsian03 mentioned this issue Feb 20, 2020
Merged
7 tasks
bsian03 added a commit to bsian03/AxonCore that referenced this issue Feb 20, 2020
@bsian03
Removed unnecessary overload. Try and link Khaaz#58 to PR?
45734e0
@Khaaz Khaaz linked a pull request Feb 20, 2020 that will close this issue
typings/ci: Split typings #59
Merged
7 tasks
Khaaz pushed a commit that referenced this issue Mar 20, 2020
@bsian03
typings/ci: Split typings (#59)
075d0fe 
* Enum documentation fixes

* Lint types folder (soon)

* Split typings

* Codefactor

* Removed unnecessary overload. Try and link #58 to PR?

* Should fix CI

* Reflect correction in 27d7d9c

* Added library typings

* Add rest of typings

* Typo

* Finished rest of library typings, bug fixes etc

* Export file, bug fixes, typos etc

* Typings change

* Naming typos

* Attempt 2

* b85c399, 22610d8 and df13457 reflections

* b854f61 reflections

* b8f415f reflections

* 9139554 reflections

* 7631742 reflections

* b0563ac reflections

* 95c586c reflections and bug fixes from previous commit

* 6296f7c reflections

* 21b3014 reflections

* 21b3014 reflections

* 38d7b34 reflections

* Added WinstonLogger

* Lint

* Don't emit file outputs on tsc check

* Add updateDBVal type

* Changed name

* Add path references

* fix

* Fix the damn CI

* Correct path

* 37a4838 and previous reflections

* f0978c2 reflections

* #64 reflections

* Clear warnings from e69bf1c

* 3ff2100 reflections

* e5bcc33 reflections

* Confirmed typo

* #65 reflections

* Rename

* #67 reflections

* Remove unused imports

* Added Library selector postinstall script, needs testing

* Remove language check/selection

* Remove variable in global

* Constant

* Move to scripts folder

* Exit process if CI detected

* Add CI env vars

* #69 reflections

* Added name to dep install and test

* Consistency

* #72 reflections

* Add first and sweep methods

* Test something

* Fix pathing

* Trying something...

* module declaration?

* Fix typings

* Return `this` where appropriate

* Save json only if invalid config

* Bump events to 13.9.2

* #70 reflections

* #66 reflections

* 0af8a88 reflections

* #73 reflections

* 061de33 reflections
@Khaaz Khaaz closed this as completed Mar 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
t: typings
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

typings/ci: Split typings bsian03/AxonCore
2 participants
@bsian03 @Khaaz