feat: adds Reaction Collector.

[sh30801]

Overview

Provides initial support for the reaction collector, and fixes #48.

@khaazz will need to review and run this version, as there are bugs on my end that prevent me from testing this.

Status

• Typings have been updated or don't need to be.
• This PR have been tested and is ready to be merged.

Semantic versioning classification

• This PR introduces BREAKING changes.
• This PR adds new features, improve the code and implies minimal changes.
• This PR fixes a bug and references the relevant issue or documentation.
• This PR improve performance or code refactor without API changes.
• This PR only includes non-code changes (documentation, CI, tools...).

[Khaaz]

I'm just pointing out this with eventemitter.
I'll try to run that tomorrow and will review more if it needs review.

TSlint failing is fine (not your fault).
However you will need to fix eslint.

[bsian03]

TSlint failing is fine (not your fault).

To elaborate, the fix will be applied when I've finished with #42 - I am still working on it at the moment. If you need TypeScript typings, please keep this open and I'll do them as I don't really fancy having conflicts everywhere, especially how now index.d.ts is very outdated

[Khaaz]

Besides These few point, the code looks good at first glance.
I'll try to run it now.
You should be able to run it as well by fixing these critical point.

On a side note when fixing eslint, you'll need to switch your editor to LF instead of CRLF in order to fix all eslint line ending issue. Most of others eslint issues are autofixable.

[Khaaz]

To elaborate, the fix will be applied when I've finished with #42 - I am still working on it at the moment. If you need TypeScript typings, please keep this open and I'll do them as I don't really fancy having conflicts everywhere, especially how now index.d.ts is very outdated

We will most likely merge this with the typings as Neu did. You will be able to just ignore the changes from this file when merging and copy paste the relevant typings in your PR with no issues I think.

[Khaaz]

Reminder that lint-ts failing is normal.
Was this tested and functional?

JS-doc just need few adjustement as Bsian already mentionned.

[sh30801]

Reminder that lint-ts failing is normal.
Was this tested and functional?

Not sure, as I am unable to test it due to the bugs posted on the Discord.

[bsian03]

I'll lint it on my PR once you get the JSDoc copied over to the typings

[Khaaz]

Any update on this?
If this is tested and works correctly I'll do a last review and we would be ready to merge.
I would love this being merged soon so I can report the changes with current WIP #65

[Khaaz]

@Neuheit considering this haven't moved yet, I'll close this PR.
I am open to a new PR on dev branch using the new Collector API introduced in #65 (you will be able to reuse some code and mechanism on this PR though).
Copying MessageCollector mechanism with reaction collector should work correctly and simplify the code a lot.

I'll close this now, consider keeping me in touch of whether you are going to implement ReactionCollector or not.