Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HTTPError wraps full Response for typed output #366

Merged
merged 1 commit into from
Feb 2, 2025
Merged

HTTPError wraps full Response for typed output #366

merged 1 commit into from
Feb 2, 2025

Conversation

HaraldNordgren
Copy link
Contributor

@HaraldNordgren HaraldNordgren commented Dec 2, 2024 •
edited
Loading

Follow-up to #363. Go one step further lets HTTPError wrap Response to get fully typed error data.

I have:

  • Written a clear PR title and description (above)
  • Signed the Khan Academy CLA
  • Added tests covering my changes, if applicable
  • Included a link to the issue fixed, if applicable
  • Included documentation, for new features
  • Added an entry to the changelog

@HaraldNordgren HaraldNordgren force-pushed the error_body branch 3 times, most recently from 1b362fd to 16e4c7f Compare December 2, 2024 20:00
@HaraldNordgren HaraldNordgren mentioned this pull request Dec 2, 2024
Merged
6 tasks
@HaraldNordgren HaraldNordgren changed the title Return full errors HTTPError wraps full Response for typed output Dec 2, 2024
@HaraldNordgren HaraldNordgren marked this pull request as ready for review December 2, 2024 21:51
@HaraldNordgren
Copy link
Contributor Author

Ping @benjaminjkraft

benjaminjkraft
benjaminjkraft approved these changes Feb 2, 2025
View reviewed changes
Copy link
Collaborator

@benjaminjkraft benjaminjkraft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea, thanks! And luckily #363 isn't in a release yet (this would otherwise be breaking).

@benjaminjkraft benjaminjkraft merged commit 6010b63 into Khan:main Feb 2, 2025
4 checks passed
@HaraldNordgren
Copy link
Contributor Author

@benjaminjkraft Thanks!

And speaking of that, I have been using subscriptions since my first fixes without any major issues. So I think this is ready for a real release 🤩

@benjaminjkraft
Copy link
Collaborator

@HaraldNordgren done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjaminjkraft benjaminjkraft benjaminjkraft approved these changes

@csilvers csilvers Awaiting requested review from csilvers csilvers is a code owner

@dnerdy dnerdy Awaiting requested review from dnerdy dnerdy is a code owner

@StevenACoffman StevenACoffman Awaiting requested review from StevenACoffman StevenACoffman is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HaraldNordgren @benjaminjkraft