Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct string zero value in design doc #53

Merged
merged 1 commit into from
Aug 20, 2021
Merged

Correct string zero value in design doc #53

merged 1 commit into from
Aug 20, 2021

Conversation

dnerdy
Copy link
Contributor

@dnerdy dnerdy commented Aug 20, 2021

The design doc talks about the zero value for the string and *string types and then references 0 and null. This PR changes these values to "" and nil.

The design doc talks about the zero value for the `string` and `*string` types and then references `0` and `null`. This PR changes these values to `""` and `nil`.
Copy link
Collaborator

@benjaminjkraft benjaminjkraft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dnerdy dnerdy merged commit 832c0bf into main Aug 20, 2021
@benjaminjkraft benjaminjkraft deleted the dnerdy-patch-1 branch August 25, 2021 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants