-
Notifications
You must be signed in to change notification settings - Fork 350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Numeric Input] Update UI of editor #2015
Open
mark-fitzgerald
wants to merge
34
commits into
main
Choose a base branch
from
LEMS-2456-use-wonder-blocks-for-editor-ui
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+677
−439
Open
Changes from all commits
Commits
Show all changes
34 commits
Select commit
Hold shift + click to select a range
7396d11
Add headings for "Common Settings" and "Answers" sections.
b88706d
Individual answers moved to their own accordion.
c8ac23e
Move delete button to bottom of individual answer panel.
4af63e0
Move settings labels to individual answer sections.
d25188a
Update unit tests to account for Unique IDs in WB Accordion.
3a03430
Changeset
c7d6c6c
Merge branch 'main' into LEMS-2455-update-layout-editor-for-numeric-i…
b7abe6e
Remove TS comment (no good way to resolve).
17bad82
Adjust for Typescript issue.
c507630
Merge branch 'main' into LEMS-2455-update-layout-editor-for-numeric-i…
e363ae7
Remove toggle button for additional answer options, and always show t…
1724cf4
Remove unused objects from code.
8d605d2
Prettier
9531c07
Merge branch 'main' into LEMS-2455-update-layout-editor-for-numeric-i…
3967f9f
Convert general setting options to use WB Pill components.
accfafb
Correct assignment of new state when toggling heading accordion.
79535e8
Additional UI changes (better font size, wording, WB Pill, etc.)
68baa71
Additional UI changes (answer format options).
1bd7f22
Debugging.
5c62fb0
Remove debugging.
1b2674d
Add animation to accordion panels.
f4eeaea
Change option labels to fieldset/legend to improve accessibility and …
231d5c2
Changeset
cf29162
Merge branch 'main' into LEMS-2455-update-layout-editor-for-numeric-i…
817388f
Merge changes from main branch.
9ae56f5
Prettier.
4ec4756
Adjust for type checking.
b3c8124
Make answer heading show fractions and pi when the format indicates t…
eb19647
Update latest from main branch.
884693f
Update from main.
85c007a
Merge branch 'main' into LEMS-2456-use-wonder-blocks-for-editor-ui
c593ccc
Address PR comments.
c13560d
Prettier
363ecf8
Resolve TypeScript error
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
--- | ||
"@khanacademy/perseus-editor": minor | ||
--- | ||
|
||
[Numeric Input] Re-organize editor and improve its UI |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
--- | ||
"@khanacademy/perseus-editor": minor | ||
--- | ||
|
||
[Numeric Input] - Adjust editor to organize settings more logically |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love these comments, thank you very much! It really helps with preventing regressions in the future imo.