Support iOS Simulator and tvOS Simulator, plus further tvOS integration #935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ibraries. Create fat builds of external libraries if both iOS and simulator versions have been created from separate manual Xcode builds. Add Scripts/create_fat_libs.sh. Remove Scripts/package_ext_libs_ios.sh and Scripts/package_ext_libs_macos.sh.
fetchDependencies supports options for specifying which platform options to build for. Fix SPIRV-Tools builds to avoid code stripping warnings.
Create fat builds of static, dynamic & framework libraries if both iOS and simulator versions have been created from separate manual Xcode builds. Refactor scripts for creating fat libraries to reuse across projects. Add MVK_BUILT_PROD_DIR to replace use of BUILT_PRODUCTS_DIR in most scripts to allow flexibility across per-platform compilation.
Log ext lib build steps to provide user feedback. Add package_ext_libs_finish.sh script to separate packaging libraries from building them, to avoid build database conflicts. Travis only build macOS ext libs.
Use platform macros to conditionally build outstanding tvOS code. Log validation error message when tvOS code doesn't support expected functionality.
Add MVK_IOS_SIMULATOR and MVK_TVOS_SIMULATOR macros. MVKPixelFormats add disableMTLPixelFormatCapabilities(). MVKPixelFormats add disableAllMTLPixelFormatCapabilities().
Fix crash during creation of fat dSYMs. Travis only build macOS version of everything.
Merged
|
Perused the diff and it's looking really great. I appreciate you including tvOS in this effort, and all the documentation updates! I will give this a try tomorrow with my app. |
Happy to do so! tvOS is an valuable addition to MoltenVK. Thanks for taking the initiative to drive that forward and make it happen! |
|
@cdavis5e This is a mostly structural, rather than behavioural update, but since it affects a lot of files, I thought I'd give you a chance to review before I pull it in. |
cdavis5e
requested changes
Jun 24, 2020
Minor doc fixes from PR review.
|
@cdavis5e Thanks for the review and feedback. Should be good to go now. Please accept changes and I'll pull it in. |
cdavis5e
approved these changes
Jun 24, 2020
|
BTW, I tested this earlier with my app and it worked great on both iOS and tvOS simulators! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR represents initial Simulator support.
The iOS and tvOS Simulators provide a subset of Metal functionality available on the native platforms. This results in a reduced set of Vulkan functionality, relative to that available on the actual iOS and tvOS platforms.
Making up these differences will require a combination of ongoing MoltenVK development on the simulator platforms, and app development (in apps that intend to use the simulator) to work around any outstanding differences.
For example, known issues include: