MVKDevice: Advertise VK_FORMAT_A2B10G10R10_UNORM_PACK32 as a surface format. #939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…format. The corresponding Metal format is now documented as supported for `CAMetalLayer`, confirming my findings in KhronosGroup#673. Only support the 10-10-10-2 formats on macOS. iOS and tvOS instead have extended-range formats, which unfortunately have no Vulkan equivalents. I've added them anyway for completeness. I suppose if Vulkan ever does get these formats, we'll then be ready to expose them as surface formats.
Merged
|
Looks good! How about |
Nope. |
|
What happened? This time, it didn't even fail to build the external dependencies. It just abruptly aborted with no output after finishing that. |
billhollings
requested changes
Jun 26, 2020
billhollings
approved these changes
Jun 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The corresponding Metal format is now documented as supported for
CAMetalLayer, confirming my findings in #673.Only support the 10-10-10-2 formats on macOS. iOS and tvOS instead have
extended-range formats, which unfortunately have no Vulkan equivalents.
I've added them anyway for completeness. I suppose if Vulkan ever does
get these formats, we'll then be ready to expose them as surface
formats.