OpenXR loader: partial fix for XRLOADER_DISABLE_EXCEPTION_HANDLING #405
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work left: adjust JNIPP to support no-exceptions mode.
Tested by building the following two configurations (based on the parameters that maintainer-scripts/build-aar.sh script is passing to cmake):
cmake -S . -B out/exceptions -G Ninja -DCMAKE_TOOLCHAIN_FILE=/usr/local/google/code/clankium/src/third_party/android_ndk/build/cmake/android.toolchain.cmake -DCMAKE_ANDROID_NDK=/usr/local/google/code/clankium/src/third_party/android_ndk/ -DANDROID_ABI=arm64-v8a -DANDROID_PLATFORM=24 -DANDROID_STL=c++_static -DCMAKE_BUILD_TYPE=Release -DBUILD_TESTS=OFF -DBUILD_CONFORMANCE_TESTS=OFF -DBUILD_LOADER=ON -DBUILD_API_LAYERS=OFF
cmake -S . -B out/no-exceptions -G Ninja -DCMAKE_TOOLCHAIN_FILE=/usr/local/google/code/clankium/src/third_party/android_ndk/build/cmake/android.toolchain.cmake -DCMAKE_ANDROID_NDK=/usr/local/google/code/clankium/src/third_party/android_ndk/ -DANDROID_ABI=arm64-v8a -DANDROID_PLATFORM=24 -DANDROID_STL=c++_static -DCMAKE_BUILD_TYPE=Release -DBUILD_TESTS=OFF -DBUILD_CONFORMANCE_TESTS=OFF -DBUILD_LOADER=ON -DBUILD_API_LAYERS=OFF -DBUILD_LOADER_WITH_EXCEPTION_HANDLING=OFF