Add Roughness float values to MetalRoughMap.cs #407
Conversation
| { | ||
| get { return _material.GetFloat("_Glossiness"); } | ||
| set { _material.SetFloat("_Glossiness", (float)value); } | ||
| } |
There was a problem hiding this comment.
Does this render correctly? Glossiness is the inverse of roughness. I do see that MetallicRoughnessTexture in the cs files refers to MetallicGlossMap in the shaders. Is this an optimization to use the same variable to hold different values for the different shader variants? It seems odd to me.
There was a problem hiding this comment.
It is very odd. Im not sure exactly what the deal is. In the PbrMetallicRoughness.shader file, it has
_Glossiness("Roughness Factor", Range(0.0, 1.0)) = 1.0
as the shader parameter. I tested in babylonjs (see pictures) and it renders the same in the editor with the change.
Best I can tell, is that PbrMetallicRoughness.shader and PbrSpecularGlossiness.shader both use UnityStandardInput.cginc, which uses _Glossiness. These shaders also use a couple unity internal cginc files, which I assume require the _Glossiness parameter as well. Though without digging through it, I can only speculate.
But, like I said, it works.
babylonjs (left) vs Unity (right)
Add Roughness float values to MetalRoughMap.cs
If the GLTF has a float value for the roughness, set it in the texture