Animation Export (WIP) #533
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hybridherbst
force-pushed
the
animation-export
branch
from
4ceaffd to
76caf97
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As I wrote in #531, animation export works fine in the Sketchfab fork of UnityGLTF. I was able to bring over the relevant parts to get both animated objects as well as animated skinned meshes working.
Biggest challenge were some of the coordinate system conversion changes in the last years, but I got it to a point where it "works" but at least one place is not pretty.
Naming-wise, this is still WIP (I left most methods from the fork with their lowercase naming to be able to compare them easier for now); happy to change the naming if this has a chance of being merged in.
Looking forward to feedback - Sketchfab's fork was labeled "beta" without them really explaining what is/isn't supported. So far the stuff I tried was working.
Example exports:
https://sleet-kookaburra.glitch.me/