Fixed #726 - Tangent issues with Draco compression #727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…reating the draco attribute map with all the other mesh attributes
|
Issue: #726 |
|
Thanks @pfcDorn – if you feel the draco docs should be improved, can you open an issue there? (you can cc me as well) |
|
@pfcDorn do we need to guard this with an ifdef against the older draco package? (which is in other places still supported as optional dependencies). |
|
i don't think so, is already in an ifdef because of API changes. The only reason for another ifdef could be for an error message that tangents are not supported by older drago versions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To fix the issue,
we now create a proper Attribute Id Map for Draco. Before it was only created for weights and joints. For Tangents this seems not to be enough. I also added all other Mesh Attribute Ids with this change.
Test File:
Preview.zip