-
Notifications
You must be signed in to change notification settings - Fork 474
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the CullPrimitiveEXT VUID's #2475
base: main
Are you sure you want to change the base?
Fix the CullPrimitiveEXT VUID's #2475
Conversation
0ce6b9b
to
370033f
Compare
- Remove VUID 07037 that wrongly was needing the builtin to be of type array - Updated the VUID 7036 to make the type a boolean value
370033f
to
35c1e28
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I don't think this is correct. When CullPrimitiveEXT is part of a Block, it must be a plain bool, but if it's declared as a standalone OpVariable, i.e. not in a Block, it must be an array of booleans, so I think this VUID needs to cover both cases. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not correct I think as stated above.
GLSL spec has folowing definition
Then the array validation rule will applly to all the other builtins like PrimitiveId , Layer etc? Because currently none of the other builtins have such a validation rule |
We will then probably need new VUID's for each of the above builtins. Kindly review these three new VUID's for CullPrimitiveEXT, i can replicate it for all the other builtins:
|
Fixes bug https://gitlab.khronos.org/vulkan/vulkan/-/issues/3296