Specify that the stored size of headerVersion in VkPipelineCacheHeaderVersionOne is 4 bytes #2477
Conversation
|
|
| @@ -7838,10 +7838,10 @@ with identical pipeline identifiers in the same pipeline cache. | |||
|
|
|||
| Unlike most structures declared by the Vulkan API, all fields of this | |||
| structure are written with the least significant byte first, regardless of | |||
| host byte-order. | |||
| host byte-order, and the headerVersion field is written as exactly 4 bytes. | |||
There was a problem hiding this comment.
This is the SC-specific version of the structure (which should be updated as well). The vulkan version is at line 7793.
And we suspect there might be other structures which need similar language.
There was a problem hiding this comment.
- VkDeviceFaultVendorBinaryHeaderVersionOneEXT the same language and should be updated as well.
- VkValidationCacheHeaderVersionEXT has a table which explicitly lists the offsets, so it might be ok.
- VulkanSC also has VkPipelineCacheHeaderVersionSafetyCriticalOne structure and the validationVersion field needs the same handling.
Feels like maybe we should make a common include for two paragraphs that are replicated numerous places. (Might need to parameterize it by the intended structure size).
There was a problem hiding this comment.
Feels like maybe we should make a common include for two paragraphs that are replicated numerous places. (Might need to parameterize it by the intended structure size).
No need for a separate include - write it in one place then use asciidoc transclusion like we do for boilerplate in the limits and features structs.
Pedantic fix. C/C++ allow enums to be larger than 4 bytes. This specifies that the stored VkPipelineCacheHeaderVersion in VkPipelineCacheHeaderVersionOne is exactly 4 bytes.