Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

glTF Sample Viewer Enhancements: Phase Concept #281

Closed
wants to merge 113 commits into from
Closed

glTF Sample Viewer Enhancements: Phase Concept #281

wants to merge 113 commits into from

Conversation

UX3D-becher
Copy link
Contributor

This pull request contains the contributions to the sample viewer from the concept phase.

RFP 3.1

RFP 3.2

RFP 3.3

RFP 3.4

  • Adapt to latest changes in KHR_texture_basisu

RFP 3.5

  • Adapt to latest state of KHR_materials_transmission
  • Update glTF sample models for KHR_materials_transmission
  • Adapt to latest state of KHR_materials_clearcoat
  • Update glTF sample models for KHR_materials_clearcoat
  • Adapt to laters state of KHR_materials_sheen
  • Update glTF sample models for KHR_materials_sheen

RFP 3.7

This pull request also contains the changes from the bugfixing phase

RFP 3.8

Also fixes a bug where front facing normals were falsely interpreted as back facing and flipped even if the material was not double sided.

UX3D-becher and others added 30 commits November 4, 2020 14:51
@UX3D-becher
add worldspace normal debug output
45e72b8
@UX3D-labode
Fix attenuation for spot/point lights with negativ/zero range
ac234fd
@UX3D-becher
fix step interpolation
6a6e2d8
@UX3D-becher
fix step rotation interpolation
501f54b
@UX3D-labode
Apply ambient occlusion only to diffuse part of IBL. Not to direct li…
f6beb38 
…ghting or specular.
@UX3D-becher
transform normals to [0,1] in debug output
bfbf2df
@UX3D-labode
Merge pull request #1 from ux3d/fix/worldspace_normals_debug
877bfa8 
add worldspace normal debug output
@jim-ec
Remove headless rendering code
13b4cdd
@jim-ec
Remove offline Electron code
abf2aae
@jim-ec
Update GitHub URL
dca1c4c
@jim-ec
Update Readme
c3b2af5
@UX3D-labode
Merge pull request #2 from ux3d/fix/step_animation
87a2574 
Fix/step animation
@UX3D-becher
self document backfacing code
b642b71
@UX3D-becher
fix backfacing detection for weird mesh normals
0144dd1
@UX3D-becher
debug view for geometry normals
a6ec8b4
@jim-ec
Drop extensions: Specular, Subsurface, Anisotropy, Thin film, Thickne…
d648982 
…ss, IoR, Absorption
@UX3D-becher
Merge pull request #6 from ux3d/fix/ambient_occlusion_order
de6f6b4 
Apply Ambient Occlusion only to IBL (diffuse part)
@UX3D-goll
Remove automatic adding of lights, if theres no light on gltf
c2f95b8
@UX3D-becher
Merge pull request #5 from ux3d/fix/removeObsoleteContent
d1125b5 
Fix: Remove obsolete content
@UX3D-haertl
Merge pull request #4 from ux3d/fix/edge_bug
a74701a 
Fix/edge bug
@UX3D-haertl
Deleted file and update licence property
ac6f8b5
@UX3D-becher
Merge pull request #8 from ux3d/release/bugfixes
e21a986 
Release/bugfixes
@UX3D-becher
Merge pull request #7 from ux3d/fix/cleanup
b7ed3a3 
Deleted file and update licence property
@UX3D-labode
fix scene extent calculation
dd02c69
@UX3D-labode
Quit scaling the scene instead of changing the camera. Fit camera pla…
1f8ca72 
…nes to scene extents
@UX3D-labode
calculate pan speed depending on scene extents
d0dfef7
@UX3D-labode
do not update each frame, it does not matter anyway
f9f48e4
@UX3D-becher
Merge pull request #10 from ux3d/enhancement/removeLightsAutomatism
4d4cbbb 
Remove automatic adding of lights, if theres no light on gltf
@UX3D-labode
use epsilon instead of zero for minimal near plane distance
bc8893f
@UX3D-labode
set near plane to a value relative to the far plane distance/glTF size
c38b8b9
UX3D-labode and others added 24 commits November 20, 2020 14:57
@UX3D-labode
remove unneeded comments
62bc920
@UX3D-hohenester
updated models subrepository
d74400c
@UX3D-becher
Merge pull request #18 from ux3d/feature/update_sheen
3d9bd80 
Feature/update sheen
@UX3D-becher
Merge pull request #20 from ux3d/feature/update_clearcoat
53e2b88 
Feature/update clearcoat
@UX3D-becher
Merge pull request #19 from ux3d/feature/update_transmission
c11e5ac 
Feature/update transmission
@UX3D-nopper
Quick compilation error fix.
d8f3626
@UX3D-hohenester
code cleanup/ simplification
17e131b
@UX3D-becher
updated models
36475bd
@UX3D-becher
set new binary formats as such in gitattributes
64da7c9
@UX3D-becher
add test suite integration
9a39b00
@UX3D-becher
added UI proposal to document
aba391a
@UX3D-becher
renamed document
3e220fc
@UX3D-becher
fix spelling
532b2c2
@UX3D-becher
add headless GL example
82ea33a
@UX3D-nopper
Updated feature list.
c0c17dc
@UX3D-becher
Merge pull request #15 from ux3d/refactor/api
d949e63 
api refactoring proposal
@UX3D-becher
Update README.md
419aa9f
@UX3D-becher
rename proposal document to README.md
3e1b818
@UX3D-becher
Update README.md
2b2a3fa
@UX3D-becher
Update README.md
c1c6da5
@UX3D-becher
Update README.md
bf0d545
@UX3D-hohenester
Merge branch 'develop' into feature/dracoImport
cba3f8a 
# Conflicts:
#	assets/models
#	index.html
#	src/main.js
@UX3D-becher
formatting and removed confusing comment
ac70046
@UX3D-becher
Merge pull request #23 from ux3d/feature/dracoImport
453251d 
Feature/draco import
@CLAassistant
Copy link

CLAassistant commented Nov 25, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@echadwick-artist
Copy link
Contributor

Can you please resolve the conflicting PDF?

Conflicting files
documentation/documents/UI_proposal.pdf

@UX3D-becher
Copy link
Contributor Author

we can just close this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
10 participants
@UX3D-becher @CLAassistant @echadwick-artist @UX3D-labode @jim-ec @UX3D-goll @UX3D-haertl @UX3D-hohenester @UX3D-bernhardt @UX3D-nopper