Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to archive stale pull requests? #1548

Closed
pjcozzi opened this issue Jan 25, 2019 · 4 comments
Closed

How to archive stale pull requests? #1548

pjcozzi opened this issue Jan 25, 2019 · 4 comments
Labels
needs discussion Issue or PR requires working group discussion to resolve.

Comments

@pjcozzi
Copy link
Member

pjcozzi commented Jan 25, 2019

There are several glTF spec/extension pull requests that are potentially good ideas but have lost momentum. They would benefit from someone picking them back up if they are a priority enough for someone to bring over the finish line.

How should we archive these PRs? For example:

  • Just close them. They will still show up in searches.
  • Assign the archive label (or whatever name we like) and keep them open.
  • Assign the archive label and close them.
@donmccurdy
Copy link
Contributor

donmccurdy commented Jan 27, 2019

I’d suggest we close these issues. I don’t think the “archive” label has an obvious significance when applied to proposed extensions, but don’t have a better suggestion either. Maybe “needs support” or “needs owner”? In many of the issues above, unless wider interest solidifies, I think a vendor extension would be more appropriate than KHR.

Property animation might be the exception on the list for me; it seems almost inevitable that we’ll want to pick that one back up eventually. But starting a fresh PR would be fine there too if the current author prefers.

@pjcozzi
Copy link
Member Author

pjcozzi commented Jan 28, 2019

I’d suggest we close these issues...Property animation might be the exception on the list for me

OK with me. Any other thoughts?

@emackey
Copy link
Member

emackey commented Jan 30, 2019

I don't think we need a label, just close them. Future users are more likely to search for a topic of interest rather than an archive label.

@pjcozzi
Copy link
Member Author

pjcozzi commented Jan 31, 2019

Seems like folks are OK with just closing them - works for me - will do as we review them, thanks!

@pjcozzi pjcozzi closed this as completed Jan 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs discussion Issue or PR requires working group discussion to resolve.
Projects
None yet
Development

No branches or pull requests

3 participants