Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We should have all flavors of converted models in sampleModels folder (Binary, Materials_Common etc) #517

Closed
tparisi opened this issue Jan 6, 2016 · 3 comments

Comments

@tparisi
Copy link
Contributor

tparisi commented Jan 6, 2016

@pjcozzi @tfili can we get glTF-Embedded, glTF-MaterialsCommon and glTF-Binary versions of each model in the sampleModels folder? This is for completeness and also will help me test the data: URI feature with Three.js.

FWIW I'm not implementing the Binary extension right now, so that won't help me for Three.js; however we should have them for completeness.

@pjcozzi
Copy link
Member

pjcozzi commented Jan 6, 2016

There already are all of these variations for several of the models, for example: https://github.com/KhronosGroup/glTF/tree/master/sampleModels/boxAnimated

@tparisi
Copy link
Contributor Author

tparisi commented Jan 6, 2016

Understood but it would be good to have them all if possible. Not highest priority. But for completeness.

This was referenced Apr 21, 2016
@pjcozzi
Copy link
Member

pjcozzi commented Apr 26, 2016

Fixed in #579.

@pjcozzi pjcozzi closed this as completed Apr 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants