Add es modules and update to babel 7 #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit: - Update Babel version to 7 - Replace babel preset es2015 to env (now supports only this one) - Add es module, supported by webpack >=4 - Fix bug: replace prepublish to prepublishOnly (prepublish run on EVERY install, prepublishOnly only before upload to npm, see more: https://docs.npmjs.com/misc/scripts ) So, after this commit, Webpack>=4 will use a tree-shaking, when simple import: `import { CaretRight } from 'react-bytesize-icons'`. It's much easier then `import CaretRight from 'react-bytesize-icons/CaretRight'`. But this way will be work fine too. and can be usefull, if you don't use es modules. My benchmark (Create-react-app application) show this result: - An old version `import { CaretRight } from 'react-bytesize-icons'`: 5.75 KB gzipped. - An old version `import CaretRight from 'react-bytesize-icons/CaretRight'`: 255 B gzipped. - A new version `import { CaretRight } from 'react-bytesize-icons'`: 231 B gzipped. - A new version `import CaretRight from 'react-bytesize-icons/CaretRight'`: 295 B gzipped.
|
This looks really good @vslutov! Let me test it and then I'll merge it. I have a pretty busy week so if I don't get to it in the next 7 or so days, please bug me about it. |
|
Hi, @Kilian ! You asked me to remain about this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, thanks for your work, this repository is awesome!
To improve awesomeness, I propose add an es modules into the build.
Webpack>=4 and rollup.js can use tree-shaking with this type of modules. So simple
import { CaretRight } from 'react-bytesize-icons'will increase bundle size by tiny bytes. Now it grows at 5 KB. And it's much easier than #9, but that way will be work fine too (can be usefull, if your bundler doesn't support tree shaking).This commit:
install, prepublishOnly only before upload to npm, see more:
https://docs.npmjs.com/misc/scripts )
So, after this commit, Webpack>=4 will use a tree-shaking, when simple
import:
import { CaretRight } from 'react-bytesize-icons'.I have tested this method on a create-react-app with an import of a single icon. Size of a minified imported code:
import { CaretRight } from 'react-bytesize-icons':5.75 KB gzipped.
import CaretRight from 'react-bytesize-icons/CaretRight':272 B gzipped.
import { CaretRight } from 'react-bytesize-icons': 229 B gzipped.import CaretRight from 'react-bytesize-icons/CaretRight':271 B gzipped.