Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Miscellanous small enhancements #79

Merged
merged 7 commits into from
Nov 13, 2023
Merged

Miscellanous small enhancements #79

merged 7 commits into from
Nov 13, 2023

Conversation

rkingsbury
Copy link
Member

@rkingsbury rkingsbury commented Nov 13, 2023 •
edited
Loading

Summary

Major changes:

  • Adjust default value of D for temperature and concentration (previously the default was returned directly)
  • Bump tox minimum version and shift python support window
  • Some Quantity optimizations

@codecov Codecov
Copy link

codecov bot commented Nov 13, 2023 •
edited
Loading

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Files Coverage Δ
src/pyEQL/engines.py 76.21% <75.00%> (ø)
src/pyEQL/solution.py 83.43% <73.33%> (ø)

📢 Thoughts on this report? Let us know!

@rkingsbury rkingsbury added enhancement release:patch will issue a patch release housekeeping pkg Package and repository health labels Nov 13, 2023
@rkingsbury rkingsbury merged commit 0c749b8 into main Nov 13, 2023
15 of 16 checks passed
@rkingsbury rkingsbury deleted the bugfix branch November 13, 2023 03:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement housekeeping pkg Package and repository health release:patch will issue a patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@rkingsbury