Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🚧Remove colon from text for controls #16

Closed
5 tasks done
CalvinWilkinson opened this issue Jun 29, 2024 · 2 comments · Fixed by #23
Closed
5 tasks done

🚧Remove colon from text for controls #16

CalvinWilkinson opened this issue Jun 29, 2024 · 2 comments · Fixed by #23
Assignees
@CalvinWilkinson
Labels
🧨breaking-changes Feature/changes contains breaking changes 💎enhancement An improvement on something high-priority High Priority preview Done while in preview
Milestone
v1.0.0-preview.3

Comments

@CalvinWilkinson
Copy link
Member

CalvinWilkinson commented Jun 29, 2024 •
edited
Loading

Complete The Item Below

  • I have updated the title without removing the 🚧 emoji.

Description

Remove the addition of the : character from the following controls

  1. ComboBox
  2. Slider
  3. UpDown

Reason: This will give more control to the user in case they do not want to have the colon character as part of the text.

Acceptance Criteria

The items to complete to satisfy the Definition of Done.
Preview Give feedback

ToDo Items

The items to complete to satisfy the Definition of Done.
Preview Give feedback

Issue Dependencies

No response

Related Work

No response

Additional Information:

Unit Tests

Reasons for local unit test execution:

  • Unit tests might pass locally but not in the CI environment during the status check process or vice-versa.
  • Tests might pass on the developer's machine but not necessarily on the code reviewer's machine.
  • If you notice that the test status check has passed but the test failed locally, please notify a project maintainer!

💡Warning💡
If the unit tests pass remotely and are not executed locally, this means we could be letting a bug slip into production.
Though bugs will always exist in some capacity, we should all do our part to help prevent them from happening.

Change Type Labels

Change Type Label
Bug Fixes 🐛bug
Breaking Changes 🧨breaking changes
New Feature ✨new feature
CICD Changes ♻️cicd
Config Changes ⚙️config
Performance Improvements 🏎️performance
Code Doc Changes 🗒️documentation/code
Product Doc Changes 📝documentation/product

Priority Type Labels

Priority Type Label
Low Priority low priority
Medium Priority medium priority
High Priority high priority

Code of Conduct

  • I agree to follow this project's Code of Conduct.
@CalvinWilkinson CalvinWilkinson added high-priority High Priority preview Done while in preview 💎enhancement An improvement on something 🧨breaking-changes Feature/changes contains breaking changes labels Jun 29, 2024
@CalvinWilkinson CalvinWilkinson self-assigned this Jun 29, 2024
@github-project-automation github-project-automation bot moved this to ⚪Not Set in KD-Team Jun 29, 2024
@CalvinWilkinson CalvinWilkinson added this to the v1.0.0-preview.3 milestone Jun 29, 2024
@CalvinWilkinson CalvinWilkinson moved this from ⚪Not Set to 🏗️In Development in KD-Team Jul 17, 2024
CalvinWilkinson added a commit that referenced this issue Jul 17, 2024
@CalvinWilkinson
Start work for issue #16
5157b17
@CalvinWilkinson CalvinWilkinson mentioned this issue Jul 17, 2024
Merged
1 task
@CalvinWilkinson
Copy link
Member Author

Note

The Slider control did not need to be updated.

@CalvinWilkinson
Copy link
Member Author

CalvinWilkinson commented Jul 17, 2024 •
edited
Loading

Note

The UpDown control did not need to be updated.

CalvinWilkinson added a commit that referenced this issue Jul 17, 2024
@CalvinWilkinson
🚧Remove colon from text for controls (#23)
ff029b9 
* Start work for issue #16

* chore!: add a colon to the default label value of the updown control

* chore!: add a colon to the default label value of the combo box control

* chore!: remove auto adding of colon to label

* test: create ctor tests for button control
@github-project-automation github-project-automation bot moved this from 🏗️In Development to ✅Done in KD-Team Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@CalvinWilkinson CalvinWilkinson

Labels
🧨breaking-changes Feature/changes contains breaking changes 💎enhancement An improvement on something high-priority High Priority preview Done while in preview
Projects
KD-Team
Archived in project
Milestone
v1.0.0-preview.3
Development

Successfully merging a pull request may close this issue.

🚧Remove colon from text for controls KinsonDigital/KdGui
1 participant
@CalvinWilkinson