Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🚧Remove nullable reference in scene manager #967

Closed
5 tasks done
CalvinWilkinson opened this issue May 15, 2024 · 0 comments · Fixed by #1003
Closed
5 tasks done

🚧Remove nullable reference in scene manager #967

CalvinWilkinson opened this issue May 15, 2024 · 0 comments · Fixed by #1003
Assignees
@CalvinWilkinson
Labels
area:scenes Changes related to scenes and scene management 🧨breaking-changes Feature/changes contains breaking changes medium-priority Medium Priority preview Done while in preview tech-debt Code refactoring or cleanup / tech debt reduction
Milestone
v1.0.0-preview.38

Comments

@CalvinWilkinson
Copy link
Member

CalvinWilkinson commented May 15, 2024 •
edited
Loading

Complete The Item Below

  • I have updated the title without removing the 🚧 emoji.

Description

In the internal SceneManager class, the list of scenes contains a tuple where the IScene in that tuple is a nullable reference type.

This should not be the case. Refactor the code in the SceneManager class to remove the IScene as a nullable reference type.

Acceptance Criteria

The items to complete to satisfy the Definition of Done.
Preview Give feedback

ToDo Items

The items to complete to satisfy the Definition of Done.
Preview Give feedback

Issue Dependencies

Related Work

No response

Additional Information:

Unit Tests

Reasons for local unit test execution:

  • Unit tests might pass locally but not in the CI environment during the status check process or vice-versa.
  • Tests might pass on the developer's machine but not necessarily on the code reviewer's machine.
  • If you notice that the test status check has passed but the test failed locally, please notify a project maintainer!

💡Warning💡
If the unit tests pass remotely and are not executed locally, this means we could be letting a bug slip into production.
Though bugs will always exist in some capacity, we should all do our part to help prevent them from happening.

Change Type Labels

Change Type Label
Bug Fixes 🐛bug
Breaking Changes 🧨breaking changes
New Feature ✨new feature
CICD Changes ♻️cicd
Config Changes ⚙️config
Performance Improvements 🏎️performance
Code Doc Changes 🗒️documentation/code
Product Doc Changes 📝documentation/product

Priority Type Labels

Priority Type Label
Low Priority low priority
Medium Priority medium priority
High Priority high priority

Code of Conduct

  • I agree to follow this project's Code of Conduct.
@CalvinWilkinson CalvinWilkinson added tech-debt Code refactoring or cleanup / tech debt reduction medium-priority Medium Priority labels May 15, 2024
@CalvinWilkinson CalvinWilkinson added this to the v1.0.0-preview.37 milestone May 15, 2024
@CalvinWilkinson CalvinWilkinson self-assigned this May 15, 2024
@github-project-automation github-project-automation bot moved this to ⚪Not Set in KD-Team May 15, 2024
@CalvinWilkinson CalvinWilkinson moved this from ⚪Not Set to 🏗️In Development in KD-Team May 15, 2024
CalvinWilkinson added a commit that referenced this issue Aug 16, 2024
@CalvinWilkinson
Start work for issue #967
c07892c
@CalvinWilkinson CalvinWilkinson added the preview Done while in preview label Aug 16, 2024
@CalvinWilkinson CalvinWilkinson mentioned this issue Aug 16, 2024
Merged
1 task
@CalvinWilkinson CalvinWilkinson added the 🧨breaking-changes Feature/changes contains breaking changes label Aug 16, 2024
CalvinWilkinson added a commit that referenced this issue Aug 16, 2024
@CalvinWilkinson
🚧Remove nullable reference in scene manager (#1003)
58b3881 
* Start work for issue #967

* BREAKING CHANGE: move exception to another namespace

* chore: create new exception for when scenes do not exist

* tech-debt: refactor code to remove nullable reference
@github-project-automation github-project-automation bot moved this from 🏗️In Development to ✅Done in KD-Team Aug 16, 2024
CalvinWilkinson added a commit that referenced this issue Aug 16, 2024
@CalvinWilkinson
🚧Remove nullable reference in scene manager (#1003)
a0236d5 
* Start work for issue #967

* BREAKING CHANGE: move exception to another namespace

* chore: create new exception for when scenes do not exist

* tech-debt: refactor code to remove nullable reference

* ci: fix label in workflow
@CalvinWilkinson CalvinWilkinson added the area:scenes Changes related to scenes and scene management label Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@CalvinWilkinson CalvinWilkinson

Labels
area:scenes Changes related to scenes and scene management 🧨breaking-changes Feature/changes contains breaking changes medium-priority Medium Priority preview Done while in preview tech-debt Code refactoring or cleanup / tech debt reduction
Projects
KD-Team
Archived in project
Milestone
v1.0.0-preview.38
Development

Successfully merging a pull request may close this issue.

🚧Remove nullable reference in scene manager KinsonDigital/Velaptor
1 participant
@CalvinWilkinson