Cleaning up ABI encoding to correctly encode function calls as tuples #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also adding other Int/UInt ABIValueTypes
pr0zac
force-pushed
the
fixing_abi_encoding
branch
from
43c42a9 to
fc8cc58
Compare
EtherKit/ABI.swift
Outdated
| for tupleElem in value { | ||
| let elemData = tupleElem.encode() | ||
|
|
||
| if tupleElem.isDynamic { |
There was a problem hiding this comment.
nit: probably better as a guard
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also removing the FunctionSelector class and just wrapping everything into Function since its cleaner that way. Also adding other Int/UInt ABIValueTypes.