Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added createdAt timestamp to cache element #78

Merged
merged 1 commit into from
Feb 5, 2019
Merged

Conversation

Andrew-Lees11
Copy link
Contributor

Description

This change adds a timestamp to the BaseCacheElement with the time that the user profile was created. This can then be used either by the user or by a plugin implementation to clear elements of the cache if they have not been used for a certain period of time.

Motivation and Context

This has bee added in response to issue #75. Once a credentials has validated a token it will trust and link that token to the user profile indefinitely. This means if the token is later revoked by the provider, this will not be picked up by Credentials.

@djones6 djones6 merged commit 4012937 into master Feb 5, 2019
@djones6 djones6 deleted the cacheTimestamp branch February 5, 2019 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants