Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Stencil 0.13 for Swift >4.0 #38

Merged
merged 1 commit into from
Oct 30, 2018
Merged

Conversation

djones6
Copy link
Contributor

@djones6 djones6 commented Oct 30, 2018

Stencil 0.13 fixes a number of compilation warnings when compiling on Swift 4.0 or higher. It also contains a number of (non-breaking) enhancements. This PR moves us up to that version.

Unfortunately Stencil 0.13.1 (the current latest tag) is incompatible with Swift 4.0, as it relies on 4.1 features. A PR has been merged to restore 4.0 support, but this has not yet been tagged. In the meantime we can continue to use Stencil 0.11 when building with Swift 4.0.

Copy link
Contributor

@Andrew-Lees11 Andrew-Lees11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@djones6 djones6 merged commit aa6d40d into master Oct 30, 2018
@djones6 djones6 deleted the issue.stencil_0_13 branch October 30, 2018 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants