Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Swift 5 #44

Merged
merged 7 commits into from
Apr 11, 2019
Merged

Support Swift 5 #44

merged 7 commits into from
Apr 11, 2019

Conversation

DunnCoding
Copy link
Contributor

Update to Swift 5, and use official Docker images for CI.

@DunnCoding DunnCoding requested a review from ianpartridge April 10, 2019 11:59
ianpartridge
ianpartridge reviewed Apr 10, 2019
View reviewed changes
Copy link
Contributor

@ianpartridge ianpartridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make the Travis consistent with our other repos.

Also there are a lot of compiler warnings in the build logs - looks like the wrong version of Stencil is being used on Swift 4.

@ianpartridge ianpartridge merged commit 398d731 into master Apr 11, 2019
@ianpartridge ianpartridge deleted the swift5 branch April 11, 2019 12:34
@ianpartridge ianpartridge mentioned this pull request Apr 11, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ianpartridge ianpartridge ianpartridge approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DunnCoding @ianpartridge @kilnerm