Build against Swift 5 #283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I believe we need #278 for the tests to pass (consistently) with Swift 5. I'd like to understand that fix better first though. |
djones6
force-pushed
the
issue.swift5
branch
from
6e8b6c9 to
18e987b
Compare
|
Rebased branch on top of #278 |
ianpartridge
approved these changes
Nov 30, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds testing with a Swift 5 development snapshot. The snapshot is defined in Travis as
SWIFT_DEVELOPMENT_SNAPSHOTconsistently across the IBM-Swift repos, to enable us to automate updating the version.