-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
COMP: Use modern macro for name of class #69
Conversation
When preparing for the future with ITK by setting ITK_FUTURE_LEGACY_REMOVE:BOOL=ON ITK_LEGACY_REMOVEBOOL=ON The future preferred macro should be used │ - itkTypeMacro │ + itkOverrideGetNameOfClassMacro
@dzenanz Part of slicer update preparations. |
1 similar comment
@dzenanz Part of slicer update preparations. |
Deprecated `itkTypeMacro` and `itkTypeMacroNoParent`, in favor of `itkOverrideGetNameOfClassMacro` and `itkVirtualGetNameOfClassMacro`, respectively.
It looks like you need to apply clang-format. |
Should the new clang format be applied to Remote modules? |
@dzenanz FYI: I upgraded to match the tooling of ITK. |
311c945
to
16ab621
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need to bump this:
itk-branch: release-5.4 |
from 5.4 to master to make CI green.
Perhaps after merging InsightSoftwareConsortium/ITKClangFormatLinterAction#7. |
I tried to do this here, but there are errors:
|
When preparing for the future with ITK by setting
ITK_FUTURE_LEGACY_REMOVE:BOOL=ON
ITK_LEGACY_REMOVEBOOL=ON
The future preferred macro should be used
│ - itkTypeMacro
│ + itkOverrideGetNameOfClassMacro