Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Board_defs.py: Add stm32g0b0 to definitions #6646

Merged
merged 1 commit into from
Jul 18, 2024

Conversation

bryan065
Copy link
Contributor

@bryan065 bryan065 commented Jul 14, 2024

Added board definition for stm32g0b0xx variant of the SKR Mini v3.0.

I couldn't flash this variant of the board with the flash_sdcard.sh script and had to add an additional definition.

Signed-off-by: Bryan Le [email protected]

Added board definition for stm32g0b0xx variant of the SKR Mini v3.0.
@bryan065 bryan065 changed the title Add stm32g0b0xx to board_defs.py Add stm32g0b0 to board_defs.py Jul 14, 2024
@bryan065 bryan065 changed the title Add stm32g0b0 to board_defs.py Board_defs.py: Add stm32g0b0 to definitions Jul 15, 2024
@JamesH1978
Copy link
Collaborator

JamesH1978 commented Jul 17, 2024

Thankyou for submitting a PR

There is no need to define a new definition, you only need to create a new alias 'btt-skr-mini-e3-v3-b0': BOARD_DEFS['btt-skr-mini-v3'],

You can see this method being used for other boards in the same family in the file.

Thanks
James

@bryan065
Copy link
Contributor Author

That was the first thing I tried as it's the same method used for other boards of the family. If I just add the alias, this is the error I'm getting below as I have the stm32g0b0 variant of the SKR mini 3.0. The board definition for 'btt-skr-mini-v3' targets the stm32g0b1.

image

@JamesH1978
Copy link
Collaborator

Yes, you are completely right. same connections, different chip, so an alias cant be used.

Copy link
Collaborator

@JamesH1978 JamesH1978 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me

Thanks
James

@KevinOConnor KevinOConnor merged commit 12cd1d9 into Klipper3d:master Jul 18, 2024
1 check passed
@KevinOConnor
Copy link
Collaborator

Thanks.

-Kevin

tobyfu pushed a commit to tobyfu/klipper that referenced this pull request Aug 7, 2024
Added board definition for stm32g0b0xx variant of the SKR Mini v3.0.

Signed-off-by: Bryan Le <[email protected]>
Misterke pushed a commit to Misterke/klipper that referenced this pull request Nov 1, 2024
Added board definition for stm32g0b0xx variant of the SKR Mini v3.0.

Signed-off-by: Bryan Le <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants