Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update generic-bigtreetech-skr-mini-e3-v3.0.cfg #6654

Merged
merged 2 commits into from
Jul 27, 2024

Conversation

MilesTheGOAT
Copy link
Contributor

@MilesTheGOAT MilesTheGOAT commented Jul 25, 2024

SKR Mini E3 V3 Config Corrections

I have made some changes to the current SKR Mini E3 V3 config example that helps to eliminate some troubles I was facing after installation, and using the sample config:

  • Removed stealth from the extruder motor to stop under-extrusion issues
  • Changed bed sensor to correct stock Ender 3 sensor

Signed-off-by: Miles Pawar [email protected]

- Removed stealth from Extruder to stop under extrusion issues
- Changed Bed sensor to correct one for Ender 3
@JamesH1978
Copy link
Collaborator

Thank you for submitting a PR, please provide a signed off by line as outlined in https://github.com/Klipper3d/klipper/blob/master/docs/CONTRIBUTING.md

Changes look fine, but please remove the comments

Thanks
James

@MilesTheGOAT MilesTheGOAT marked this pull request as draft July 25, 2024 14:59
@MilesTheGOAT MilesTheGOAT marked this pull request as ready for review July 25, 2024 17:01
@MilesTheGOAT
Copy link
Contributor Author

Thank you for submitting a PR, please provide a signed off by line as outlined in https://github.com/Klipper3d/klipper/blob/master/docs/CONTRIBUTING.md

Changes look fine, but please remove the comments

Thanks James

Hi James,

Updated the config and removed the comments and reformatted the request.

Miles

Copy link
Collaborator

@JamesH1978 JamesH1978 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me, user might not want stealth, and spread is default, and as this is a board primarily meant for ender replacement, then they stock ender thermistor makes sense.

Thanks
James

@KevinOConnor KevinOConnor merged commit 0844388 into Klipper3d:master Jul 27, 2024
1 check passed
@KevinOConnor
Copy link
Collaborator

Thanks.

-Kevin

tobyfu pushed a commit to tobyfu/klipper that referenced this pull request Aug 7, 2024
- Removed stealth from Extruder to stop under extrusion issues
- Changed Bed sensor to correct one for Ender 3

* Update generic-bigtreetech-skr-mini-e3-v3.0.cfg

Signed-off-by: Miles Pawar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants