Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

probe: Added truncated mean averaging capability #6778

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nickweedon
Copy link

Added a new samples_trunc_count configuration attribute to the '[probe]' section that will cause the samples_trunc_count number of highest and lowest samples to be removed and then the average of the remaining samples is returned.

This feature is very useful when performing 5 samples or more since it will allow for the 'best of both worlds' with regard to using either median or mean (average) since it gives the converging benefit of mean while still being resistant to outliers like median.
This works particularly well when also combined with samples_tolerance_retries.

@nickweedon nickweedon force-pushed the truncated_mean branch 2 times, most recently from a07afb6 to 4b78010 Compare January 4, 2025 18:57
Added a new 'samples_trunc_count' configuration attribute to the
'[probe]' section that will cause the 'samples_trunc_count' number of
highest and lowest samples to be removed and then the average of the
remaining samples is returned.

Signed-off-by: Nick Weedon <[email protected]>
Copy link

Thank you for your contribution to Klipper. Unfortunately, a reviewer has not assigned themselves to this GitHub Pull Request. All Pull Requests are reviewed before merging, and a reviewer will need to volunteer. Further information is available at: https://www.klipper3d.org/CONTRIBUTING.html

There are some steps that you can take now:

  1. Perform a self-review of your Pull Request by following the steps at: https://www.klipper3d.org/CONTRIBUTING.html#what-to-expect-in-a-review
    If you have completed a self-review, be sure to state the results of that self-review explicitly in the Pull Request comments. A reviewer is more likely to participate if the bulk of a review has already been completed.
  2. Consider opening a topic on the Klipper Discourse server to discuss this work. The Discourse server is a good place to discuss development ideas and to engage users interested in testing. Reviewers are more likely to prioritize Pull Requests with an active community of users.
  3. Consider helping out reviewers by reviewing other Klipper Pull Requests. Taking the time to perform a careful and detailed review of others work is appreciated. Regular contributors are more likely to prioritize the contributions of other regular contributors.

Unfortunately, if a reviewer does not assign themselves to this GitHub Pull Request then it will be automatically closed. If this happens, then it is a good idea to move further discussion to the Klipper Discourse server. Reviewers can reach out on that forum to let you know if they are interested and when they are available.

Best regards,
~ Your friendly GitIssueBot

PS: I'm just an automated script, not a human being.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant