Simplify kinematic set_position() and clear_homing_state() calls #6782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I cherry-picked and tried to test it: I got klippy crashed: |
nefelim4ag
reviewed
Jan 12, 2025
klippy/extras/force_move.py
Outdated
| axes = ['X', 'Y', 'Z'] | ||
| clear_axes = [axes.index(a) for a in axes if a in clear] | ||
| clear = gcmd.get('CLEAR', '').lower() | ||
| clear_axes = "".join([a for a in "xyz" if a in clear]) | ||
| logging.info("SET_KINEMATIC_POSITION pos=%.3f,%.3f,%.3f clear=%s", | ||
| x, y, z, ','.join((axes[i] for i in clear_axes))) |
There was a problem hiding this comment.
Missing axes[i]
Possibly there should be:
i for i in clear_axes
There was a problem hiding this comment.
Oops! Thanks for testing and reporting. Hopefully should be fixed now.
-Kevin
KevinOConnor
force-pushed
the
work-stepper-20250110
branch
from
3e62be4 to
38de633
Compare
Call clear_homing_state() on each motor off event. This simplifies the kinematic classes as they no longer need to register and handle the motor_off event. Signed-off-by: Kevin O'Connor <[email protected]>
Use strings such as "xyz" to specify which axes are to be considered homing during a set_position() call. This makes the parameter a little less cryptic. Signed-off-by: Kevin O'Connor <[email protected]>
Pass a string such as "xyz" to kin.clear_homing_state(). This makes the parameter a little less cryptic. Signed-off-by: Kevin O'Connor <[email protected]>
KevinOConnor
force-pushed
the
work-stepper-20250110
branch
from
38de633 to
6ab2533
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that clear_homing_state() has been implemented, there is no longer a need for each kinematic class to manually register for the "motor_off" event, as the stepper_enable class can directly call clear_homing_state().
Also this changes the homing_axes and clear_axes parameters of the set_position() and clear_homing_state() to pass strings (eg, "xyz") instead of a list of numbers.
@twelho - fyi.
-Kevin