-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
self.sortData has javascript error 'sortInfo is not defined' in 2 spots #174
Comments
This should fix the issue :). Thanks for finding that! |
OK so after that fix my computed function which responds to any changes to sortInfo gets called twice. See fiddle console log for example http://jsfiddle.net/zSpMh/3/. Do I have to change the way I do my computed function? Or maybe does that new hotfix need to change? |
I want to say that self.sortInfo has a reference to self.config.sortInfo because if you evaluate self.sortInfo() === self.config.sortInfo() in that self.sortData function it always evaluates to true. Not sure if that helps. |
I'll look into it, I am going to change the title but it should only get called once. |
I'm also getting into the same problem. The serverside sorting gets called twice. Thanks for KoGrid, BTW. :) |
sortInfo gets called twice, is this issue fixed? |
The sortInfo variable is not defined and therefore throws a javascript Uncaught ReferenceError: sortInfo is not defined. You can see it in the following fiddle as well - http://jsfiddle.net/zSpMh/2/ after you try sorting the first column.
The text was updated successfully, but these errors were encountered: