Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop removing obsoletes #61

Closed
caufieldjh opened this issue Aug 19, 2022 · 0 comments · Fixed by #62
Closed

Stop removing obsoletes #61

caufieldjh opened this issue Aug 19, 2022 · 0 comments · Fixed by #62

Comments

@caufieldjh
Copy link
Contributor

In a followup to #15, discussion with @cmungall , comments re: UI needs here, and recognition that KG-Phenio is being fed directly into the Monarch ingest, obsolete nodes/edges can come back.

See https://github.com/Knowledge-Graph-Hub/kg-phenio/blob/3ac0ea11a20343d6c42c768c1b579b64c492937d/kg_phenio/transform_utils/phenio/phenio_transform.py - can just stop calling remove_obsoletes.
@caufieldjh caufieldjh linked a pull request Aug 19, 2022 that will close this issue
Return obsoletes to the graph #62
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Return obsoletes to the graph Knowledge-Graph-Hub/kg-phenio
1 participant
@caufieldjh