Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exlude obsolete terms from autocomplete #454

Open
pgaudet opened this issue Nov 8, 2017 · 2 comments
Open

Exlude obsolete terms from autocomplete #454

pgaudet opened this issue Nov 8, 2017 · 2 comments

Comments

@pgaudet
Copy link

pgaudet commented Nov 8, 2017

Hello,

We'd like to exclude obsolete terms from the autocomplete feature of AmiGO.
Obsolete terms should be searchable (at least by ID) but it would be less confusing if they were not shown in the autocomplete.

Thanks, Pascale

@kltm kltm changed the title AmiGO autocomplete: exlude obsolete terms Exlude obsolete terms from autocomplete Nov 9, 2017
@kltm kltm added this to the wishlist milestone Nov 9, 2017
@kltm
Copy link
Member

kltm commented Nov 9, 2017

There is currently no data in the general index for obsoletion. While the UI parts are easy, we'll have to add an obsolete field to the index and populate that appropriately for ontology classes. It shouldn't be difficult, but will have to be coordinated with an embedded release of owltools as well as a schema update.

@cmungall
Copy link
Member

cmungall commented Jan 8, 2021

We'd like to exclude obsolete terms from the autocomplete feature of AmiGO.
Obsolete terms should be searchable (at least by ID) but it would be less confusing if they were not shown in the autocomplete.

I agree they should remain searchable. I would say there is no reason to restrict it to ID. Often a user may have in mind a term that they perceive to be in scope for GO but which we think is not, and have obsoleted. E.g histolysis. We should allow them to search for the concept and to arrive at an explanation of why we have not included as a true term.

We should have very clear behavior around obsoletes in search

  • obsolete results should be downweighted (ideally this would happen naturally, if we downweight less used terms)
  • there should be a clear visual indication of obsoletion status. Currently we do this in the name by prefixing with "obsolete", which is good, as it guarantees we have some indication across all tools and portals, but UIs should do more, e.g strikethrough

Regarding behavior in autocomplete. I think it's confusing to have different logic between search and AC. The user searching for an obsolete concept will expect AC results. However, given the smaller set of terms returned in AC, and the lack of context, the recommendations above are even more important, to avoid obsoletes flooding results. An obsolete should never be prioritized over a non-obsolete (perhaps except in the case of an exact match)

There is currently no data in the general index for obsoletion. While the UI parts are easy, we'll have to add an obsolete field to the index and populate that appropriately for ontology classes. It shouldn't be difficult, but will have to be coordinated with an embedded release of owltools as well as a schema update.

I think we really need to do this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants