You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Not quite done with assignment of node categories correctly in KG-Phenio.
The fix in #31 prevents node categories from getting overwritten if we've included them in RETAINED_CAT_LIST and they're already defined in a nodefile.
So if HP:0000123 has biolink:PhenotypicFeature before normalization, it will still have that category after normalization.
But if a node comes in with biolink:OntologyClass, we still try to rewrite it, and that means accepting whatever the last detail we have about the category is (with the assumption that it's the most detailed).
e.g., for MP:0000018:
The last edge is biolink:category of biolink:PhenotypicQuality, so the node category for MP:0000018 becomes biolink:PhenotypicQuality.
Not correct in this case, though it may be correct in others.
The text was updated successfully, but these errors were encountered:
Not quite done with assignment of node categories correctly in KG-Phenio.
The fix in #31 prevents node categories from getting overwritten if we've included them in
RETAINED_CAT_LIST
and they're already defined in a nodefile.So if HP:0000123 has biolink:PhenotypicFeature before normalization, it will still have that category after normalization.
But if a node comes in with biolink:OntologyClass, we still try to rewrite it, and that means accepting whatever the last detail we have about the category is (with the assumption that it's the most detailed).
e.g., for MP:0000018:
The last edge is biolink:category of biolink:PhenotypicQuality, so the node category for MP:0000018 becomes biolink:PhenotypicQuality.
Not correct in this case, though it may be correct in others.
The text was updated successfully, but these errors were encountered: