Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new Knowville AWS organizer images #5

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

arjunrbery
Copy link

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Image Submissions:

  1. Does your submission match the PR you sent to the Directory?

    • Is the image you include correspond to the cluster file you submitted to the Directory?

    e.g. if you submitted a group file, the photo you are submitting here IS the logo for that group?

    Note, any submission that does not adhere to this will be denied a PR. Please keep in mind the Code of Conduct when submtting.

    • Does the name of the file corresponding to the image / logo EXACTLY match the name (but all lowercase) of the cluster submitting to.

    e.g. If there is a space in the name, _ is used in the filename to denote a space.

    Please note file names must be all lowercase.

    • The name of the PR makes explicit what the image being contributed to is.

New Feature Submissions:

  1. Does your submission pass tests?
  2. Have you lint your code locally prior to submission?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant