Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Long descriptions for people are being cut off. #18

Open
vt102 opened this issue Jun 13, 2018 · 5 comments
Open

Long descriptions for people are being cut off. #18

vt102 opened this issue Jun 13, 2018 · 5 comments
Assignees
@alexpawlowski
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@vt102
Copy link
Contributor

vt102 commented Jun 13, 2018

Is your feature request related to a problem? Please describe.
As a user, I see information about individuals on your website that is terminated with "...", but there is no way to see the rest of the information.

Describe the solution you'd like
I would like some way to see the rest of the information-- perhaps a JS popup panel that has the user's description in its entirity.

Describe alternatives you've considered
n/a

Additional context
Add any other context or screenshots about the feature request here.

screen shot 2018-06-13 at 12 52 45 pm
@alexpawlowski
Copy link
Member

As the site doesn't use bootstrap, I don't want to include bootstrap for this solution. Similarly, jquery can be hit or miss with mobile (but doable).

I think maybe the best solution is to just remove the strict 50 character count and just ensure when users add their information for organizers, group, etc., they don't get carried away with the excess character count.

@alexpawlowski alexpawlowski self-assigned this Jun 15, 2018
@alexpawlowski alexpawlowski added enhancement New feature or request good first issue Good for newcomers labels Jun 15, 2018
@alexpawlowski alexpawlowski reopened this Jun 15, 2018
@alexpawlowski
Copy link
Member

What do you think @vt102 ? Is that an okay solution?

@vt102
Copy link
Contributor Author

vt102 commented Jun 15, 2018

We're all volunteers here, I don't think it should be the site maintainers job to enforce limits. If we don't want a pop out, I'd suggest:

  1. Leave as-is for now.
  2. Eventually provide a test contributors can run which would error out if their description is too long. Require PRs to pass tests.

alexpawlowski added a commit that referenced this issue Jun 15, 2018
@alexpawlowski
Separate CoC and Organizers from About
9b010a0 
- Make it cleaner and more obvious when changes to Code of Conduct are needed
- Directly link to Code of Conduct if changes are needed.
- Remove 50 character limit from the organizer description (#18)
@alexpawlowski alexpawlowski mentioned this issue Jun 15, 2018
Merged
11 tasks
@alexpawlowski
Copy link
Member

I think that sounds good. For now, I removed the description limit in #20.

If someone would like to make a JS popup, that would be a good pull request!

I'll leave this issue open to facilitate that.

@alexpawlowski alexpawlowski added the help wanted Extra attention is needed label Jun 15, 2018
@alexpawlowski
Copy link
Member

To add to description woes. If the description is over 330 characters, it's cut off and then ruins the html markup. Which... is weird.

Cut off after 330 characters

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexpawlowski alexpawlowski

Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vt102 @alexpawlowski