Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New device naviclim atlantic #4560

Merged
merged 20 commits into from
Sep 7, 2022
Merged

New device naviclim atlantic #4560

merged 20 commits into from
Sep 7, 2022

Conversation

Noneangel
Copy link
Contributor

I tried to add a new device support: an HVAC embedded thermostat (naviclim).
It mostly works, except for the part I wrote.

Could someone help me to address these problems? I will comment the file for each of them with a wireshark log of the sniff I made with the native hub.

Noneangel
Noneangel commented Aug 24, 2022
View reviewed changes
devices/atlantic.js Outdated Show resolved Hide resolved
Noneangel
Noneangel commented Aug 24, 2022
View reviewed changes
devices/atlantic.js Outdated Show resolved Hide resolved
Noneangel
Noneangel commented Aug 24, 2022
View reviewed changes
devices/atlantic.js Outdated Show resolved Hide resolved
Noneangel
Noneangel commented Aug 24, 2022
View reviewed changes
devices/atlantic.js Outdated Show resolved Hide resolved
@Noneangel
Copy link
Contributor Author

By the way, the option e.programming_operation_mode speaks of a schedule. Is there a way to program the schedule?

@Noneangel Noneangel marked this pull request as ready for review August 24, 2022 22:55
@Noneangel Noneangel changed the title New device naviclim atlantic New device naviclim atlantic - Help needed Aug 24, 2022
@Koenkk
Copy link
Owner

Koenkk commented Aug 25, 2022

By the way, the option e.programming_operation_mode speaks of a schedule. Is there a way to program the schedule?

Is this possible with the original hub?

@Noneangel
Copy link
Contributor Author

By the way, the option e.programming_operation_mode speaks of a schedule. Is there a way to program the schedule?

Is this possible with the original hub?

Probably not. The app of the hub provide it, but it must be backed by a server. I was thinking that maybe I missed something because it is possible to do some kind of programming with if IR remote (sleep, on/off at a specific time).
Thank you for the help and your fantastic project.

@Noneangel Noneangel changed the title New device naviclim atlantic - Help needed New device naviclim atlantic Aug 25, 2022
@Noneangel Noneangel marked this pull request as draft August 25, 2022 17:54
@Noneangel Noneangel marked this pull request as ready for review August 25, 2022 18:29
Koenkk
Koenkk reviewed Aug 26, 2022
View reviewed changes
devices/atlantic.js Outdated Show resolved Hide resolved
Koenkk
Koenkk reviewed Aug 26, 2022
View reviewed changes
devices/atlantic.js Outdated Show resolved Hide resolved
Koenkk
Koenkk reviewed Aug 26, 2022
View reviewed changes
devices/atlantic.js Outdated Show resolved Hide resolved
@Noneangel
Copy link
Contributor Author

I would like to develop and use a new feature: swing mode for HVAC for the home assistant extension.
For this, I need:

  1. hvac swing mode #4590 to be merged
  2. update this pull request to use the change in 1 and merge it.
  3. wait for zigbee-herdsman-converters to be updated in zigbee2mqtt
  4. add test to pass ci in hvac swing mode zigbee2mqtt#13784

@Noneangel Noneangel mentioned this pull request Sep 2, 2022
Merged
@Koenkk Koenkk merged commit ff86d00 into Koenkk:master Sep 7, 2022
@Koenkk
Copy link
Owner

Koenkk commented Sep 7, 2022

Thanks!

Mephistofeles pushed a commit to Mephistofeles/zigbee-herdsman-converters that referenced this pull request Dec 13, 2022
@Noneangel @Mephistofeles
Add GW003-AS-IN-TE-FC (Koenkk#4560)
c60e27b 
* wip: new device naviclim

* refactor: remove debug code

* fix: position 0 does not exist

* style: spelling

* fix: quiet_fan can now be disabled

* fix: add manufacturerCode

* fix: cluster for louber position is hvacThermostat

* refactor: user enum instead of hardcoded number

* fix: data type for swing mode

* fix: add manufacturerCode

* fix: disable powerful mode before activating eco

* feat: custom thermostat_programming_operation_mode to return state

* style: sort ToZigbee function

* feat: add presence detection

* feat: update state after tz.thermostat_occupied_cooling_setpoint

* feat: update state after tz.thermostat_occupied_heating_setpoint

* feat: update state after tz.thermostat_programming_operation_mode

* feat: use withSwingMode, an migrate to preset for eco, activity and boost

* fix: set state for swingMode

* fix: remove presence_detection (replaced with preset)

Co-authored-by: Noneangel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Koenkk Koenkk Koenkk left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Noneangel @Koenkk