Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add subsplease #44

Closed
wants to merge 4 commits into from
Closed

add subsplease #44

wants to merge 4 commits into from

Conversation

vvirtues
Copy link
Contributor

@vvirtues vvirtues commented Jul 11, 2024

Checklist:

  • Updated extVersionCode value in build.gradle for individual extensions
  • Updated overrideVersionCode or baseVersionCode as needed for all multisrc extensions
  • Referenced all related issues in the PR body (e.g. "Closes #xyz")
  • Added the isNsfw = true flag in build.gradle when appropriate
  • Have not changed source names
  • Have explicitly kept the id if a source's name or language were changed
  • Have tested the modifications by compiling and running the extension through Android Studio
  • Have removed web_hi_res_512.png when adding a new extension

@vvirtues vvirtues marked this pull request as ready for review July 19, 2024 11:40
@vvirtues
Copy link
Contributor Author

i havent tested but its from another repo so it should be fine

@Dark25
Copy link
Collaborator

Dark25 commented Jul 22, 2024

image
This is important, please review it

@almightyhak
Copy link
Contributor

please properly test the extension then i will merge with the main branch

@almightyhak almightyhak deleted the branch Kohi-den:master August 7, 2024 13:48
@almightyhak almightyhak closed this Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants