Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Encapsulate model download in a function #81

Merged
merged 5 commits into from
Jan 5, 2024
Merged

Encapsulate model download in a function #81

merged 5 commits into from
Jan 5, 2024

Conversation

j3mdamas
Copy link
Contributor

@j3mdamas j3mdamas commented Jan 4, 2024

Hi @Kohulan,

Here is the PR related with my comment on #70 (comment)

I tried to follow your coding style, feel free to edit or adjust my PR.

Best,
João

Kohulan and others added 5 commits September 22, 2023 12:14

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Development

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
fix: remove tensorflow_addons
@Kohulan
Copy link
Owner

Kohulan commented Jan 4, 2024

HI @j3mdamas ,

Thanks a lot for the pull request. I will merge once all checks are passed.

Kind regards,
Kohulan

@j3mdamas
Copy link
Contributor Author

j3mdamas commented Jan 4, 2024

The release job is failing due to lack of token

@Kohulan Kohulan changed the base branch from master to development January 5, 2024 08:41
@Kohulan Kohulan merged commit 208752a into Kohulan:development Jan 5, 2024
@j3mdamas j3mdamas deleted the feature/issue-70/allow-model-location-definition branch January 9, 2024 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants