Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modernization of dependencies #26

Open
0-M opened this issue Oct 20, 2016 · 7 comments
Open

modernization of dependencies #26

0-M opened this issue Oct 20, 2016 · 7 comments
Assignees

Comments

@0-M
Copy link
Contributor

0-M commented Oct 20, 2016

hey everyone, I'm trying to do some maintenance to facilitate future features/fixes.

I'm working at mmarkman/koko

@0-M
Copy link
Contributor Author

0-M commented Oct 20, 2016

I've found that using DefinitelyTyped manually causes the project to use of older (deprecated) packages. I think it's a good idea to move towards using typings for the TS dependencies, most of which seem to be pulled from DefinitelyTyped.

Any objections?

@hatashiro
Copy link
Contributor

Sorry for the late response. This project may not be continued by me, because I don't have enough resource to contribute on this. Therefore, I'm willing to hand this project over to other contributors who are interested and would like to maintain. Please leave comments in #28 if interested.

Sorry again, and thanks.

@AriTheElk
Copy link

I have no objections to it, I think it's a good idea and necessary for the future of koko. Do you have your fork building fine with those changes or are you still working on it?

@0-M
Copy link
Contributor Author

0-M commented Nov 10, 2016

it's building fine but not all features are working @garetmckinley

@AriTheElk
Copy link

Alright. Is it something that you'll be able to tackle yourself or would you rather commit the changes to a branch in this repository so we could tag team some of the issues?

@0-M
Copy link
Contributor Author

0-M commented Nov 10, 2016

I need to clean up a lot of the source and then I'll merge it to a dev
branch on this repo
On Wed, Nov 9, 2016 at 17:41 Garet McKinley [email protected]
wrote:

Alright. Is it something that you'll be able to tackle yourself or would
you rather commit the changes to a branch in this repository so we could
tag team some of the issues?


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#26 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/ADe-u-dmcmMF7HexeP3bSjG5Zul-ro6lks5q8nZigaJpZM4Kbz8Z
.

@0-M
Copy link
Contributor Author

0-M commented Nov 10, 2016

Then we can evaluate how the work can be split if necessary before merging
into master
On Wed, Nov 9, 2016 at 17:43 Max M [email protected] wrote:

I need to clean up a lot of the source and then I'll merge it to a dev
branch on this repo
On Wed, Nov 9, 2016 at 17:41 Garet McKinley [email protected]
wrote:

Alright. Is it something that you'll be able to tackle yourself or would
you rather commit the changes to a branch in this repository so we could
tag team some of the issues?


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#26 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/ADe-u-dmcmMF7HexeP3bSjG5Zul-ro6lks5q8nZigaJpZM4Kbz8Z
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants