Enable clippy --all-features on CI

[rozhkovdmitrii]

#1745
There were a lot of warning if cargo clippy --all-features -- -D warnings is started to check. These warnings have been suppressed meanwhile with cfg(test)

[laruh]

LGTM!

[onur-ozkan]

Instead of ignoring the warnings, I was expecting to apply what clippy says just like we did in #1699 for all other modules other than solana.

--

please check the warnings with --all-targets flag cargo clippy --all-targets --all-features -- -D warnings. You might miss some warnings without it.

[laruh]

please check the warnings with --all-targets flag cargo clippy --all-targets --all-features -- -D warnings. You might miss some warnings without it.

As we missed warnings in dev, I suggest changing the cargo clippy -- -D warnings command to cargo clippy --all-targets --all-features -- -D warnings in contributing file. The whole project should be clean, without warnings.

[onur-ozkan]

It was cargo clippy -- -D warnings on previous CI stack. In current stack it's cargo clippy --all-targets -- -D warnings, once we have --all-features working without warnings I will update that too.

[rozhkovdmitrii]

Instead of ignoring the warnings, I was expecting to apply what clippy says just like we did in #1699 for all other modules other than solana.

--

please check the warnings with --all-targets flag cargo clippy --all-targets --all-features -- -D warnings. You might miss some warnings without it.

1. That is not ignoring, as you can see the majority of warnings are "unused", but those are actually test related methods, that is why these three modules should be marked as test related

2. If the command --all-targets flag cargo clippy --all-targets --all-features -- -D warnings is used it would reveal a bit variety of warnings and even the code that can not be compiled. If you want to solve all the legacy artifacts it would be reasonable to perform it not in one huge PR but in a few from organizational point of view

3. These test are even not able to be compiled ) cargo test --no-run --features=enable-solana --release, abandoned

I think solana related problems should be solved apart, like the other groups of proplems
What do you thing? @ozkanonur

[rozhkovdmitrii]

Instead of ignoring the warnings, I was expecting to apply what clippy says just like we did in #1699 for all other modules other than solana.

--

please check the warnings with --all-targets flag cargo clippy --all-targets --all-features -- -D warnings. You might miss some warnings without it.

1. That is not ignoring, as you can see the majority of warnings are "unused", but those are actually test related methods, that is why these three modules should be marked as test related

2. If the command cargo clippy --all-targets --all-features -- -D warnings is used it would reveal a big variety of warnings and even the code that can not be compiled. If you want to solve all the legacy artifacts it would be reasonable to perform it not in one huge PR but in a few from organizational point of view

3. These test are not able to be compiled ) cargo test --no-run --features=enable-solana --release

I think solana related problems should be solved apart, like the other groups of proplems
What do you thing? @ozkanonur

[onur-ozkan]

That is not ignoring, as you can see the majority of warnings are "unused", but those are actually test related methods, that is why these three modules should be marked as test related

Yeah I see, test modules can be stay with test attribute.

If the command --all-targets flag cargo clippy --all-targets --all-features -- -D warnings is used it would reveal a bit variety of warnings and even the code that can not be compiled. If you want to solve all the legacy artifacts it would be reasonable to perform it not in one huge PR but in a few from organizational point of view

That's the idea. You will be able to see wasm warnings with providing --all-targets. I had to fix ~500 warnings because of that. And some of them were even critical.

These test are not able to be compiled ) cargo test --no-run --features=enable-solana --release

I couldn't get what you mean here

[rozhkovdmitrii]

I couldn't get what you mean here

Checked it up again, build perfect, thank you.

[rozhkovdmitrii]

Created new PR #1760